Two new commands that list conflicting policies

Author: michaelklishin

src/cli.rs

@@ -2126,6 +2126,20 @@ fn policies_subcommands(pre_flight_settings: PreFlightSettings) -> Vec<Command>
                 .value_parser(value_parser!(PolicyTarget)),
         );
 
+    let list_conflicting_cmd = Command::new("list_conflicting")
+        .about("Lists policies that have conflicting priorities across all virtual hosts")
+        .after_help(color_print::cformat!(
+            "<bold>Doc guide</bold>: {}",
+            POLICY_GUIDE_URL
+        ));
+
+    let list_conflicting_in_cmd = Command::new("list_conflicting_in")
+        .about("Lists policies that have conflicting priorities in a specific virtual host")
+        .after_help(color_print::cformat!(
+            "<bold>Doc guide</bold>: {}",
+            POLICY_GUIDE_URL
+        ));
+
     let list_matching_cmd = Command::new("list_matching_object")
         .about("Lists policies that match an object (queue, stream, exchange) name")
         .arg(
@@ -2200,6 +2214,8 @@ fn policies_subcommands(pre_flight_settings: PreFlightSettings) -> Vec<Command>
         delete_definition_keys_cmd,
         delete_definition_keys_from_all_in_cmd,
         list_cmd,
+        list_conflicting_cmd,
+        list_conflicting_in_cmd,
         list_in_cmd,
         list_matching_cmd,
         patch_cmd,

src/commands.rs

@@ -43,6 +43,7 @@ use rabbitmq_http_client::{password_hashing, requests, responses};
 use regex::Regex;
 use serde::de::DeserializeOwned;
 use serde_json::Value;
+use std::collections::HashMap;
 use std::fs;
 use std::io;
 use std::process;
@@ -154,6 +155,48 @@ pub fn list_matching_policies_in(
         .collect())
 }
 
+pub fn list_policies_with_conflicting_priorities(
+    client: APIClient,
+) -> ClientResult<Vec<responses::Policy>> {
+    let policies = client.list_policies()?;
+    Ok(filter_policies_with_conflicting_priorities(policies))
+}
+
+pub fn list_policies_with_conflicting_priorities_in(
+    client: APIClient,
+    vhost: &str,
+) -> ClientResult<Vec<responses::Policy>> {
+    let policies = client.list_policies_in(vhost)?;
+    Ok(filter_policies_with_conflicting_priorities(policies))
+}
+
+fn filter_policies_with_conflicting_priorities(
+    policies: Vec<responses::Policy>,
+) -> Vec<responses::Policy> {
+    let mut priority_counts: HashMap<(&str, i16), usize> = HashMap::new();
+
+    for pol in &policies {
+        *priority_counts
+            .entry((pol.vhost.as_str(), pol.priority))
+            .or_insert(0) += 1;
+    }
+
+    let dominated: Vec<bool> = policies
+        .iter()
+        .map(|pol| {
+            priority_counts
+                .get(&(pol.vhost.as_str(), pol.priority))
+                .is_some_and(|&count| count > 1)
+        })
+        .collect();
+
+    policies
+        .into_iter()
+        .zip(dominated)
+        .filter_map(|(pol, is_conflicting)| is_conflicting.then_some(pol))
+        .collect()
+}
+
 pub fn list_operator_policies(client: APIClient) -> ClientResult<Vec<responses::Policy>> {
     client.list_operator_policies()
 }

src/main.rs

@@ -977,6 +977,14 @@ fn dispatch_common_subcommand(
             let result = commands::list_policies(client);
             res_handler.tabular_result(result)
         }
+        ("policies", "list_conflicting") => {
+            let result = commands::list_policies_with_conflicting_priorities(client);
+            res_handler.tabular_result(result)
+        }
+        ("policies", "list_conflicting_in") => {
+            let result = commands::list_policies_with_conflicting_priorities_in(client, &vhost);
+            res_handler.tabular_result(result)
+        }
         ("policies", "list_in") => {
             let typ_opt = second_level_args
                 .get_one::<PolicyTarget>("apply_to")