Optimize default compare function

rav2040 · rav2040 · commit 9846b1eb858f · 2020-03-22T20:34:13.000+13:00
diff --git a/src/index.ts b/src/index.ts
@@ -86,7 +86,7 @@ export function stableJsonStringify(value: any, compareFn?: CompareFunction | nu
     }
 
     else {
-      compareFn = compareFn ?? defaultCompareKeys;
+      compareFn = typeof compareFn === 'function' ? compareFn : defaultCompareKeys;
 
       return Array.isArray(value)
         ? stableSerializeArray(value, compareFn, safe)
@@ -101,6 +101,6 @@ export function stableJsonStringify(value: any, compareFn?: CompareFunction | nu
   return;
 }
 
-function defaultCompareKeys([keyA]: [string, any], [keyB]: [string, any]) {
-  return keyA.localeCompare(keyB);
+function defaultCompareKeys([keyA]: string[], [keyB]: string[]) {
+  return keyA > keyB ? 1 : -1;
 }

Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,7 @@ export function stableJsonStringify(value: any, compareFn?: CompareFunction \| nu`
`86`	`86`	`}`
`87`	`87`
`88`	`88`	`else {`
`89`		`- compareFn = compareFn ?? defaultCompareKeys;`
	`89`	`+ compareFn = typeof compareFn === 'function' ? compareFn : defaultCompareKeys;`
`90`	`90`
`91`	`91`	`return Array.isArray(value)`
`92`	`92`	`? stableSerializeArray(value, compareFn, safe)`
`@@ -101,6 +101,6 @@ export function stableJsonStringify(value: any, compareFn?: CompareFunction \| nu`
`101`	`101`	`return;`
`102`	`102`	`}`
`103`	`103`
`104`		`-function defaultCompareKeys([keyA]: [string, any], [keyB]: [string, any]) {`
`105`		`- return keyA.localeCompare(keyB);`
	`104`	`+function defaultCompareKeys([keyA]: string[], [keyB]: string[]) {`
	`105`	`+ return keyA > keyB ? 1 : -1;`
`106`	`106`	`}`