From 0abbe7726038fea9b62bdbafbf614f6e363332c0 Mon Sep 17 00:00:00 2001 From: NareshM1702 Date: Thu, 30 Jul 2026 13:18:40 +0530 Subject: [PATCH 1/7] Update Start_MaintenanceTasks.sh --- lib/rdk/Start_MaintenanceTasks.sh | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/rdk/Start_MaintenanceTasks.sh b/lib/rdk/Start_MaintenanceTasks.sh index ba6671f6..88490b42 100644 --- a/lib/rdk/Start_MaintenanceTasks.sh +++ b/lib/rdk/Start_MaintenanceTasks.sh @@ -98,7 +98,6 @@ runMaintenanceRFCTask() rfcLog "No RFC Bin/ Script" result=-1 fi - touch /tmp/.RFCsynccomplete # Handle both success (0) and acceptable warning (1) exit codes, flag other results as errors if [ "$result" -ne 0 ] && [ "$result" -ne 1 ]; then eventSender "MaintenanceMGR" "$MAINT_RFC_ERROR" From b4b49231264c9234ae9cfd9da28a81969ff45154 Mon Sep 17 00:00:00 2001 From: NareshM1702 Date: Thu, 30 Jul 2026 13:27:06 +0530 Subject: [PATCH 2/7] Addressing review comments --- lib/rdk/start_ssh.sh | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/lib/rdk/start_ssh.sh b/lib/rdk/start_ssh.sh index 5ecb13cc..7c23cf87 100755 --- a/lib/rdk/start_ssh.sh +++ b/lib/rdk/start_ssh.sh @@ -74,19 +74,12 @@ checkForInterface() fi } -if [ "BUILD_TYPE" != "dev" ]; then - DEVICETYPE=$(tr181 -d Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Identity.DeviceType 2>&1 > /dev/null) - if [ "$DEVICETYPE" = "TEST" ]; then - USE_DEVKEYS="-f authorized_keys_dev" - echo " dropbear using dev authorization keys" - else - USE_DEVKEYS="" - echo " dropbear using prod authorization keys" - fi -else - USE_DEVKEYS="" - echo " Build type is dev , use dev authorization keys by default" +USE_DEVKEYS="-f authorized_keys_dev +DEVICETYPE=$(tr181 -d Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Identity.DeviceType 2>/dev/null) +if [ "$BUILD_TYPE" != "dev" -a "$DEVICETYPE" != "TEST" ]; then +USE_DEVKEYS="" fi + /bin/systemctl set-environment USE_DEVKEYS="$USE_DEVKEYS" #RFC check for MOCA SSH enable/not. From 13eaaddb608f134b9ba4e3ec1fb9e8d5481f8a6d Mon Sep 17 00:00:00 2001 From: NareshM1702 Date: Thu, 30 Jul 2026 14:36:41 +0530 Subject: [PATCH 3/7] Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --- lib/rdk/start_ssh.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/rdk/start_ssh.sh b/lib/rdk/start_ssh.sh index 7c23cf87..ada14310 100755 --- a/lib/rdk/start_ssh.sh +++ b/lib/rdk/start_ssh.sh @@ -74,10 +74,10 @@ checkForInterface() fi } -USE_DEVKEYS="-f authorized_keys_dev +USE_DEVKEYS="-f authorized_keys_dev" DEVICETYPE=$(tr181 -d Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Identity.DeviceType 2>/dev/null) -if [ "$BUILD_TYPE" != "dev" -a "$DEVICETYPE" != "TEST" ]; then -USE_DEVKEYS="" +if [ "$BUILD_TYPE" != "dev" ] && [ "$DEVICETYPE" != "TEST" ]; then + USE_DEVKEYS="" fi /bin/systemctl set-environment USE_DEVKEYS="$USE_DEVKEYS" From 17b371cb5f3a1a7da8d297b47171c279d750d70e Mon Sep 17 00:00:00 2001 From: NareshM1702 Date: Mon, 3 Aug 2026 12:57:31 +0530 Subject: [PATCH 4/7] Update start_ssh.sh --- lib/rdk/start_ssh.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rdk/start_ssh.sh b/lib/rdk/start_ssh.sh index ada14310..34c21550 100755 --- a/lib/rdk/start_ssh.sh +++ b/lib/rdk/start_ssh.sh @@ -75,7 +75,7 @@ checkForInterface() } USE_DEVKEYS="-f authorized_keys_dev" -DEVICETYPE=$(tr181 -d Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Identity.DeviceType 2>/dev/null) +DEVICETYPE=$(tr181 Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Identity.DeviceType 2>&1) if [ "$BUILD_TYPE" != "dev" ] && [ "$DEVICETYPE" != "TEST" ]; then USE_DEVKEYS="" fi From 9820041f36f71495fcf0a534d5695d2b9bcfd724 Mon Sep 17 00:00:00 2001 From: nm296 Date: Tue, 4 Aug 2026 09:49:31 +0000 Subject: [PATCH 5/7] addressing review comments --- lib/rdk/start_ssh.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/rdk/start_ssh.sh b/lib/rdk/start_ssh.sh index 34c21550..3ed1f6f6 100755 --- a/lib/rdk/start_ssh.sh +++ b/lib/rdk/start_ssh.sh @@ -75,8 +75,8 @@ checkForInterface() } USE_DEVKEYS="-f authorized_keys_dev" -DEVICETYPE=$(tr181 Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Identity.DeviceType 2>&1) -if [ "$BUILD_TYPE" != "dev" ] && [ "$DEVICETYPE" != "TEST" ]; then +DEVICETYPE=$(tr181 -g Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Identity.DeviceType 2>&1) +if [ "$BUILD_TYPE" = "prod" ] && [ "$DEVICETYPE" = "PROD; then USE_DEVKEYS="" fi From 7d9ad99e5cc1f74989f8db37a113a08d7524ed3d Mon Sep 17 00:00:00 2001 From: NareshM1702 Date: Tue, 4 Aug 2026 15:51:14 +0530 Subject: [PATCH 6/7] Update start_ssh.sh --- lib/rdk/start_ssh.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rdk/start_ssh.sh b/lib/rdk/start_ssh.sh index 3ed1f6f6..25136818 100755 --- a/lib/rdk/start_ssh.sh +++ b/lib/rdk/start_ssh.sh @@ -76,7 +76,7 @@ checkForInterface() USE_DEVKEYS="-f authorized_keys_dev" DEVICETYPE=$(tr181 -g Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Identity.DeviceType 2>&1) -if [ "$BUILD_TYPE" = "prod" ] && [ "$DEVICETYPE" = "PROD; then +if [ "$BUILD_TYPE" = "prod" ] && [ "$DEVICETYPE" = "PROD ]; then USE_DEVKEYS="" fi From 16eb744171002b490c23edfe96832599a35286c3 Mon Sep 17 00:00:00 2001 From: NareshM1702 Date: Tue, 4 Aug 2026 15:54:36 +0530 Subject: [PATCH 7/7] Update start_ssh.sh --- lib/rdk/start_ssh.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rdk/start_ssh.sh b/lib/rdk/start_ssh.sh index 25136818..77d52ac8 100755 --- a/lib/rdk/start_ssh.sh +++ b/lib/rdk/start_ssh.sh @@ -76,7 +76,7 @@ checkForInterface() USE_DEVKEYS="-f authorized_keys_dev" DEVICETYPE=$(tr181 -g Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Identity.DeviceType 2>&1) -if [ "$BUILD_TYPE" = "prod" ] && [ "$DEVICETYPE" = "PROD ]; then +if [ "$BUILD_TYPE" = "prod" ] && [ "$DEVICETYPE" = "PROD" ]; then USE_DEVKEYS="" fi