fix: fixed combobox mode not show 0 value (#968)

* fix: fixed combobox mode not show 0 value

* fix: combo mode no value just fixed 0 value

* fix: format

* fix: take review suggestion and add comment

Author: ZWkang

src/Select.tsx

@@ -50,7 +50,7 @@ import OptGroup from './OptGroup';
 import Option from './Option';
 import OptionList from './OptionList';
 import SelectContext from './SelectContext';
-import { hasValue, toArray } from './utils/commonUtil';
+import { hasValue, isComboNoValue, toArray } from './utils/commonUtil';
 import { fillFieldNames, flattenOptions, injectPropsWithOption } from './utils/valueUtil';
 import warningProps, { warningNullOptions } from './utils/warningPropsUtil';
 
@@ -307,8 +307,8 @@ const Select = React.forwardRef(
     const rawLabeledValues = React.useMemo(() => {
       const values = convert2LabelValues(internalValue);
 
-      // combobox no need save value when it's no value
-      if (mode === 'combobox' && !values[0]?.value) {
+      // combobox no need save value when it's no value (exclude value equal 0)
+      if (mode === 'combobox' && isComboNoValue(values[0]?.value)) {
         return [];
       }
 

src/utils/commonUtil.ts

@@ -17,6 +17,11 @@ export function hasValue(value) {
   return value !== undefined && value !== null;
 }
 
+/** combo mode no value judgment function */
+export function isComboNoValue(value) {
+  return !value && value !== 0;
+}
+
 function isTitleType(title: any) {
   return ['string', 'number'].includes(typeof title);
 }

tests/Combobox.test.tsx

@@ -600,4 +600,10 @@ describe('Select.Combobox', () => {
 
     jest.useRealTimers();
   });
+
+  // https://github.com/ant-design/ant-design/issues/43936
+  it('combobox mode not show 0 value', () => {
+    const wrapper = mount(<Select mode="combobox" value={0} />);
+    expect(wrapper.find('input').props().value).toBe('0');
+  });
 });