fix: defaultOpen not working (#1187)

Author: zombieJ

src/BaseSelect/index.tsx

@@ -358,8 +358,11 @@ const BaseSelect = React.forwardRef<BaseSelectRef, BaseSelectProps>((props, ref)
   // Not trigger `open` when `notFoundContent` is empty
   const emptyListContent = !notFoundContent && emptyOptions;
 
-  const [mergedOpen, triggerOpen] = useOpen(open, onPopupVisibleChange, (nextOpen) =>
-    disabled || emptyListContent ? false : nextOpen,
+  const [mergedOpen, triggerOpen] = useOpen(
+    defaultOpen || false,
+    open,
+    onPopupVisibleChange,
+    (nextOpen) => (disabled || emptyListContent ? false : nextOpen),
   );
 
   // ============================= Search =============================

src/hooks/useOpen.ts

@@ -39,6 +39,7 @@ export type TriggerOpenType = (
  * On client-side hydration, it syncs with the actual open state.
  */
 export default function useOpen(
+  defaultOpen: boolean,
   propOpen: boolean,
   onOpen: (nextOpen: boolean) => void,
   postOpen: (nextOpen: boolean) => boolean,
@@ -50,7 +51,7 @@ export default function useOpen(
     setRendered(true);
   }, []);
 
-  const [stateOpen, internalSetOpen] = useControlledState(false, propOpen);
+  const [stateOpen, internalSetOpen] = useControlledState(defaultOpen, propOpen);
 
   // During SSR, always return false for open state
   const ssrSafeOpen = rendered ? stateOpen : false;

tests/Select.test.tsx

@@ -66,6 +66,16 @@ describe('Select.Basic', () => {
     expect(onPopupVisibleChange).toHaveBeenCalledWith(false);
   });
 
+  it('should defaultOpen work', () => {
+    const { container } = render(
+      <Select defaultOpen>
+        <Option value="1">One</Option>
+        <Option value="2">Two</Option>
+      </Select>,
+    );
+    expectOpen(container);
+  });
+
   describe('render', () => {
     function genSelect(props?: Partial<SelectProps>) {
       return (