Commit 31ce522
Move AssetRegistry implementation into main package, expose as public API
Summary:
NOTE: Squash of #57233 (D108750302) and #57232 (D108750303)
**This diff** solves two distinct problems.
**Problem 1 — `react-native/assets-registry` is a stateful-singleton footgun.**
`registry.js` holds asset state in a module-scoped variable, so exactly one instance must exist per JS runtime or registration and lookup diverge. Nothing guarantees this: the `node_modules` install layout decides how many copies exist, and `react-native`'s exact-version pin means third-party ranges never dedupe against it. Consumers silently break — `expo-asset`/`expo-image` can land on a second copy where assets register in one and resolve as `undefined` from the other (Expo neutralizes this with a virtual-module shim in `expo/cli`; bare React Native + Metro has no such protection). It also blocks 1.0: the ecosystem can't move from exact-version lockstep to semver ranges until stateful packages like this are safe to duplicate.
**Problem 2 — Metro configs depend on a deep `/Libraries/...` import.**
Metro configs reference `transformer.assetRegistryPath` via a deep `react-native/Libraries/Image/AssetRegistry` import. We want to replace it with a public entry point, but we can't reuse the new index `AssetRegistry` API directly — doing so breaks Metro's API contract (it generates an inline require). We need a dedicated wrapper module that can be read without destructuring.
**This diff**
1. Moves the `AssetRegistry` implementation into the main `react-native` package, adding the `AssetRegistry` API plus the `PackagerAsset` and `AssetDestPathResolver` root type exports. `react-native/assets-registry` now sources from this relocated implementation, fixing the duplicate-install bug wherever apps/frameworks enforce a single copy of `react-native`. Imports from either package in RN 0.87+ become durable to duplicate installs, so Expo can drop their virtual-module shim.
2. Adds a new `react-native/asset-registry` secondary entry point, intended and documented for the Metro config use case, and migrates our own `react-native/metro-config` onto it (replacing the `transformer.assetRegistryPath` deep import). Deprecates `react-native/assets-registry/registry` and removes `react-native/Libraries/Image/AssetRegistry`, standardizing on `AssetRegistry` (singular) as canonical.
Changelog:
- [General][Fixed] - **assets-registry**: `react-native/assets-registry` now shares state across duplicate installs, sourcing from a relocated implementation in the `react-native` package
- [General][Added] - Add `AssetRegistry` API (replaces `react-native/assets-registry/registry`)
- [General][Breaking] - `react-native/Libraries/Image/AssetRegistry` is removed. Please use the `AssetRegistry` API (apps/library code) and/or the `react-native/asset-registry` entrypoint (Metro/build configs).
- [General][Deprecated] - **assets-registry**: `react-native/assets-registry/registry` is deprecated. Please use the `AssetRegistry` API (apps/library code) and/or the `react-native/asset-registry` entrypoint (Metro/build configs).
Differential Revision: D1090196221 parent 4a8910b commit 31ce522
22 files changed
Lines changed: 165 additions & 86 deletions
File tree
- packages
- assets-registry
- eslint-plugin-react-native
- metro-config/src
- react-native
- Libraries/Image
- __tests__
- src
- private/assets
- rn-tester
- private/helloworld
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
50 | 50 | | |
51 | 51 | | |
52 | 52 | | |
53 | | - | |
54 | 53 | | |
55 | 54 | | |
56 | 55 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
4 | | - | |
5 | | - | |
6 | | - | |
| 3 | + | |
7 | 4 | | |
8 | 5 | | |
9 | 6 | | |
| |||
13 | 10 | | |
14 | 11 | | |
15 | 12 | | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
29 | | - | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
30 | 33 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
14 | | - | |
| 13 | + | |
15 | 14 | | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
| 15 | + | |
| 16 | + | |
29 | 17 | | |
30 | 18 | | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | 19 | | |
44 | | - | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
| 35 | + | |
35 | 36 | | |
36 | 37 | | |
37 | 38 | | |
| |||
88 | 89 | | |
89 | 90 | | |
90 | 91 | | |
| 92 | + | |
91 | 93 | | |
92 | 94 | | |
93 | 95 | | |
| |||
173 | 175 | | |
174 | 176 | | |
175 | 177 | | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
176 | 186 | | |
177 | 187 | | |
178 | 188 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
84 | 84 | | |
85 | 85 | | |
86 | 86 | | |
87 | | - | |
| 87 | + | |
88 | 88 | | |
89 | 89 | | |
90 | 90 | | |
| |||
This file was deleted.
Lines changed: 12 additions & 25 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
38 | 17 | | |
39 | 18 | | |
40 | 19 | | |
| |||
45 | 24 | | |
46 | 25 | | |
47 | 26 | | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
48 | 35 | | |
49 | 36 | | |
50 | 37 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| |||
0 commit comments