Skip to content

Commit 6b3d98e

Browse files
restore two construction paths comment on parseShadowNodeProps
1 parent eb71d82 commit 6b3d98e

1 file changed

Lines changed: 9 additions & 0 deletions

File tree

packages/react-native/ReactCommon/react/renderer/core/ConcreteComponentDescriptor.h

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -215,6 +215,15 @@ class ConcreteComponentDescriptor : public ComponentDescriptor {
215215
/*
216216
* Constructs a typed props object by applying `rawProps` on top of
217217
* `sourceProps`, via one of two paths:
218+
* - Iterator-setter (only available when `ConcreteProps` satisfies
219+
* `HasIteratorSetterCtor` AND the runtime flag is on): copy-construct
220+
* from sourceProps, then walk rawProps in-place via `forEachItem` and
221+
* route each entry through `setProp`. Skips both
222+
* `RawProps::parse(parser)` and the `folly::dynamic` materialization
223+
* that the legacy path needed.
224+
* - Classic (the fallback for any `ConcreteProps` that doesn't opt in,
225+
* and the only path when the flag is off): parse + per-field
226+
* `convertRawProp` via the 3-arg ctor.
218227
*/
219228
typename ShadowNodeT::UnsharedConcreteProps parseShadowNodeProps(
220229
const PropsParserContext &context,

0 commit comments

Comments
 (0)