Commit eb4d389
fix(ios): add log advice back when using shadow w/o a background (#57618)
Summary:
Back on old arch in RCTView.m we printed that warning:
https://github.com/react/react-native/blob/d13d2b0a5f7329d5fe9262259e8f846a86312f03/packages/react-native/React/Views/RCTView.m#L898-L906
This was missing on new arch and due to it we were missing some unoptimized views in our app which tanked performance.
## Changelog:
<!-- Help reviewers and the release process by writing your own changelog entry.
Pick one each for the category and type tags:
[ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message
For more details, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->
[IOS] [ADDED] - Print warning advice when using `shadow*` styles without providing a solid background color
Pull Request resolved: #57618
Test Plan: In rn-tester go to APIs > Box Shadow example to see the warnings printed!
Reviewed By: shwanton
Differential Revision: D113008257
Pulled By: fabriziocucci
fbshipit-source-id: 912224c426641325e010ebf261ea56f0b5dfa0851 parent 5e86c32 commit eb4d389
1 file changed
Lines changed: 8 additions & 0 deletions
Lines changed: 8 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| 24 | + | |
24 | 25 | | |
25 | 26 | | |
26 | 27 | | |
| |||
1009 | 1010 | | |
1010 | 1011 | | |
1011 | 1012 | | |
| 1013 | + | |
| 1014 | + | |
| 1015 | + | |
| 1016 | + | |
| 1017 | + | |
| 1018 | + | |
| 1019 | + | |
1012 | 1020 | | |
1013 | 1021 | | |
1014 | 1022 | | |
| |||
0 commit comments