fix(android): show soft keyboard on text selection

Author: nikhilpakhloo

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactEditText.kt

@@ -130,6 +130,7 @@ public open class ReactEditText public constructor(context: Context) : AppCompat
   private var keyListener: InternalKeyListener? = null
   private var detectScrollMovement = false
   private var onKeyPress = false
+  private var selectionWasCollapsed = true
   private val textAttributes: TextAttributes
   private var typefaceDirty = false
   private var fontFamily: String? = null
@@ -492,13 +493,29 @@ public open class ReactEditText public constructor(context: Context) : AppCompat
     if (selectionWatcher != null && hasFocus()) {
       selectionWatcher?.onSelectionChanged(selStart, selEnd)
     }
+    maybeShowSoftKeyboardForSelection(selStart, selEnd)
   }
 
   override fun onFocusChanged(focused: Boolean, direction: Int, previouslyFocusedRect: Rect?) {
     super.onFocusChanged(focused, direction, previouslyFocusedRect)
     if (focused && selectionWatcher != null) {
       selectionWatcher?.onSelectionChanged(selectionStart, selectionEnd)
     }
+    if (focused) {
+      maybeShowSoftKeyboardForSelection(selectionStart, selectionEnd)
+    }
+  }
+
+  private fun maybeShowSoftKeyboardForSelection(selectionStart: Int, selectionEnd: Int) {
+    if (!hasFocus() || !showSoftInputOnFocus) {
+      return
+    }
+
+    val selectionIsCollapsed = selectionStart == selectionEnd
+    if (!selectionIsCollapsed && selectionWasCollapsed) {
+      showSoftKeyboard()
+    }
+    selectionWasCollapsed = selectionIsCollapsed
   }
 
   internal fun setSelectionWatcher(selectionWatcher: SelectionWatcher?) {

packages/react-native/ReactAndroid/src/test/java/com/facebook/react/views/textinput/ReactTextInputPropertyTest.kt

@@ -11,6 +11,7 @@
 
 package com.facebook.react.views.textinput
 
+import android.content.Context
 import android.graphics.Color
 import android.os.Build
 import android.text.InputFilter
@@ -46,6 +47,15 @@ import org.robolectric.RuntimeEnvironment
 @RunWith(RobolectricTestRunner::class)
 class ReactTextInputPropertyTest {
 
+  private class TestReactEditText(context: Context) : ReactEditText(context) {
+    var showSoftKeyboardCallCount = 0
+
+    override fun showSoftKeyboard(): Boolean {
+      showSoftKeyboardCallCount++
+      return true
+    }
+  }
+
   private lateinit var context: BridgeReactContext
   private lateinit var catalystInstanceMock: CatalystInstance
   private lateinit var themedContext: ThemedReactContext
@@ -74,6 +84,17 @@ class ReactTextInputPropertyTest {
     view = manager.createViewInstance(themedContext)
   }
 
+  @Test
+  fun testShowsSoftKeyboardWhenSelectionStartsWhileFocused() {
+    val textInput = TestReactEditText(themedContext)
+    textInput.setText("hello")
+    textInput.onFocusChanged(true, View.FOCUS_DOWN, null)
+
+    textInput.setSelection(1, 3)
+
+    assertThat(textInput.showSoftKeyboardCallCount).isEqualTo(1)
+  }
+
   @Test
   fun testAutoCorrect() {
     manager.updateProperties(view, buildStyles())