[CodeQuality] Produce void callbacks with bare return in WithCallbackIdenticalToStandaloneAssertsRector (#712)

Author: TomasVotruba

rules-tests/CodeQuality/Rector/MethodCall/WithCallbackIdenticalToStandaloneAssertsRector/Fixture/array_key_exists.php.inc

@@ -32,10 +32,10 @@ final class ArrayKeyExists extends TestCase
 
         $someMock->expects($this->any())
             ->method('trans')
-            ->with($this->callback(function (array $args): bool {
+            ->with($this->callback(function (array $args): void {
                 $this->assertArrayHasKey(5, $args);
                 $this->assertInstanceOf(\stdClass::class, $args[0]);
-                return true;
+                return;
             }));
     }
 }

rules-tests/CodeQuality/Rector/MethodCall/WithCallbackIdenticalToStandaloneAssertsRector/Fixture/arrow_with_class_variable.php.inc

@@ -32,10 +32,10 @@ final class ArrowWithClassVariable extends TestCase
         $this->createMock('SomeType')
             ->method('someMethod')
             ->with($this->callback(
-                function ($item) use ($type): bool {
+                function ($item) use ($type): void {
                     $this->assertInstanceOf($type, $item);
                     $this->assertSame('name', $item->getName());
-                    return true;
+                    return;
                 }
                 ));
     }

rules-tests/CodeQuality/Rector/MethodCall/WithCallbackIdenticalToStandaloneAssertsRector/Fixture/assert_method_call_true.php.inc

@@ -38,10 +38,10 @@ final class AssertMethodCallTrue extends TestCase
 
         $someMock->expects($this->any())
             ->method('trans')
-            ->with($this->callback(function ($arg): bool {
+            ->with($this->callback(function ($arg): void {
                 $this->assertInstanceOf(\Rector\PHPUnit\Tests\CodeQuality\Rector\MethodCall\WithCallbackIdenticalToStandaloneAssertsRector\Source\SomeClassWithMethodCall::class, $arg);
                 $this->assertTrue($arg->isReady());
-                return true;
+                return;
             }));
     }
 }

rules-tests/CodeQuality/Rector/MethodCall/WithCallbackIdenticalToStandaloneAssertsRector/Fixture/closure_instance_of.php.inc

@@ -34,10 +34,10 @@ final class ClosureInstanceOf extends TestCase
 
         $someMock->expects($this->any())
             ->method('trans')
-            ->with($this->callback(function ($args): bool {
+            ->with($this->callback(function ($args): void {
                 $this->assertCount(5, $args);
                 $this->assertInstanceOf(\stdClass::class, $args[0]);
-                return true;
+                return;
             }));
     }
 }

rules-tests/CodeQuality/Rector/MethodCall/WithCallbackIdenticalToStandaloneAssertsRector/Fixture/cover_equal.php.inc

@@ -32,10 +32,10 @@ final class CoverEqual extends TestCase
         $this->createMock('SomeType')
             ->method('someMethod')
             ->with($this->callback(
-                function ($item) use ($type): bool {
+                function ($item) use ($type): void {
                     $this->assertInstanceOf($type, $item);
                     $this->assertEquals('name', $item->getName());
-                    return true;
+                    return;
                 }
                 ));
     }

rules-tests/CodeQuality/Rector/MethodCall/WithCallbackIdenticalToStandaloneAssertsRector/Fixture/extra_stmt.php.inc

@@ -35,12 +35,12 @@ final class ExtraStmt extends TestCase
 
         $someMock->expects($this->any())
             ->method('trans')
-            ->with($this->callback(function ($args): bool {
+            ->with($this->callback(function ($args): void {
                 $item = 100;
                 $this->assertCount(5, $args);
                 $this->assertArrayHasKey(0, $args);
                 $this->assertSame('some_value', $args[0]);
-                return true;
+                return;
             }));
     }
 }

rules-tests/CodeQuality/Rector/MethodCall/WithCallbackIdenticalToStandaloneAssertsRector/Fixture/handle_solo_compare.php.inc

@@ -36,9 +36,9 @@ final class HandleSoloCompare extends TestCase
             ->method('trans')
             ->with(
                 $this->callback(
-                    function ($args): bool {
+                    function ($args): void {
                         $this->assertCount(5, $args);
-                        return true;
+                        return;
                     }
                 )
             );

rules-tests/CodeQuality/Rector/MethodCall/WithCallbackIdenticalToStandaloneAssertsRector/Fixture/handle_solo_instance.php.inc

@@ -36,9 +36,9 @@ final class HandleSoloInstance extends TestCase
             ->method('trans')
             ->with(
                 $this->callback(
-                    function ($arg): bool {
+                    function ($arg): void {
                         $this->assertInstanceOf(\stdClass::class, $arg);
-                        return true;
+                        return;
                     }
                 )
             );

rules-tests/CodeQuality/Rector/MethodCall/WithCallbackIdenticalToStandaloneAssertsRector/Fixture/handle_solo_isset.php.inc

@@ -36,9 +36,9 @@ final class HandleSoloIsset extends TestCase
             ->method('trans')
             ->with(
                 $this->callback(
-                    function ($args): bool {
+                    function ($args): void {
                         $this->assertArrayHasKey('key', $args);
-                        return true;
+                        return;
                     }
                 )
             );

rules-tests/CodeQuality/Rector/MethodCall/WithCallbackIdenticalToStandaloneAssertsRector/Fixture/include_no_args.php.inc

@@ -39,11 +39,11 @@ final class IncludeNoArgs extends TestCase
 
         $someMock->expects($this->any())
             ->method('trans')
-            ->with($this->callback(function (): bool {
+            ->with($this->callback(function (): void {
                 $args= [1, 2, 3];
                 $this->assertCount(5, $args);
                 $this->assertSame('some_value', $args[0]);
-                return true;
+                return;
             }));
     }
 }