[CodeQuality] Skip TestCase suffix classes in RemoveNeverUsedMockPropertyRector (#709)

* [CodeQuality] Add BareCreateMockAssignToDirectUseRector to phpunit-mock-to-stub set

* [CodeQuality] Skip TestCase suffix classes in RemoveNeverUsedMockPropertyRector

Abstract *TestCase classes are most likely extended, with mock properties used in child classes. Skip them to avoid removing still-used mocks.

Author: TomasVotruba

rules-tests/CodeQuality/Rector/Class_/RemoveNeverUsedMockPropertyRector/Fixture/skip_test_case_suffix.php.inc

@@ -0,0 +1,19 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\CodeQuality\Rector\Class_\RemoveNeverUsedMockPropertyRector\Fixture;
+
+use PHPUnit\Framework\MockObject\MockObject;
+use PHPUnit\Framework\TestCase;
+
+abstract class SomeAbstractTestCase extends TestCase
+{
+    private MockObject $mockProperty;
+
+    protected function setUp(): void
+    {
+        $this->mockProperty = $this->createMock(\stdClass::class);
+        $this->mockProperty->expects($this->once())
+            ->method('someMethod')
+            ->willReturn('someValue');
+    }
+}

rules/CodeQuality/Rector/Class_/RemoveNeverUsedMockPropertyRector.php

@@ -92,6 +92,11 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
+        // skip abstract test case classes, as most likely extended and mock used in child classes
+        if (str_ends_with((string) $this->getName($node), 'TestCase')) {
+            return null;
+        }
+
         $setUpClassMethod = $node->getMethod(MethodName::SET_UP);
         if (! $setUpClassMethod instanceof ClassMethod) {
             return null;