[CodeQuality] Skip AssertIssetToSpecificMethodRector on ArrayAccess objects (#692)

isset($obj[$key]) on an ArrayAccess object is not equivalent to
assertArrayHasKey($key, $obj): the key may be any type (assertArrayHasKey()
requires int|string) and offsetExists() semantics can differ from
array_key_exists(). Converting it produced code that throws for non-scalar
keys. Skip the rule when the subject is an ArrayAccess object.

Author: TomasVotruba

rules-tests/CodeQuality/Rector/MethodCall/AssertIssetToSpecificMethodRector/Fixture/skip_array_access_object.php.inc

@@ -0,0 +1,16 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\CodeQuality\Rector\MethodCall\AssertIssetToSpecificMethodRector\Fixture;
+
+use Rector\PHPUnit\Tests\CodeQuality\Rector\MethodCall\AssertIssetToSpecificMethodRector\Source\SomeArrayAccessStore;
+
+final class SkipArrayAccessObject extends \PHPUnit\Framework\TestCase
+{
+    public function test()
+    {
+        $store = new SomeArrayAccessStore();
+
+        $this->assertTrue(isset($store[$key]), 'message');
+        $this->assertFalse(isset($store[$key]));
+    }
+}

rules-tests/CodeQuality/Rector/MethodCall/AssertIssetToSpecificMethodRector/Source/SomeArrayAccessStore.php

@@ -0,0 +1,26 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\PHPUnit\Tests\CodeQuality\Rector\MethodCall\AssertIssetToSpecificMethodRector\Source;
+
+final class SomeArrayAccessStore implements \ArrayAccess
+{
+    public function offsetExists($offset): bool
+    {
+        return true;
+    }
+
+    public function offsetGet($offset): mixed
+    {
+        return null;
+    }
+
+    public function offsetSet($offset, $value): void
+    {
+    }
+
+    public function offsetUnset($offset): void
+    {
+    }
+}

rules/CodeQuality/Rector/MethodCall/AssertIssetToSpecificMethodRector.php

@@ -9,6 +9,7 @@
 use PhpParser\Node\Expr\Isset_;
 use PhpParser\Node\Expr\MethodCall;
 use PhpParser\Node\Expr\StaticCall;
+use PHPStan\Type\ObjectType;
 use Rector\PHPUnit\Enum\AssertMethod;
 use Rector\PHPUnit\NodeAnalyzer\IdentifierManipulator;
 use Rector\PHPUnit\NodeAnalyzer\TestsNodeAnalyzer;
@@ -77,6 +78,13 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
+        // isset() on an ArrayAccess object is not equivalent to assertArrayHasKey():
+        // the key may be any type (assertArrayHasKey() requires int|string) and offsetExists()
+        // semantics can differ from array_key_exists()
+        if ($this->isObjectType($issetExpr->var, new ObjectType('ArrayAccess'))) {
+            return null;
+        }
+
         return $this->refactorArrayDimFetchNode($node, $issetExpr);
     }