From 7e49e69504318dba8d765721ffc1ea98cf540982 Mon Sep 17 00:00:00 2001
From: Tomas Votruba <tomas.vot@gmail.com>
Date: Wed, 8 Jul 2026 18:25:55 +0200
Subject: [PATCH] [CodeQuality] Skip same boolean in both branches in
 SimplifyIfReturnBoolRector

---
 .../Fixture/skip_same_bool_return.php.inc       | 17 +++++++++++++++++
 .../Rector/If_/SimplifyIfReturnBoolRector.php   |  7 +++++++
 2 files changed, 24 insertions(+)
 create mode 100644 rules-tests/CodeQuality/Rector/If_/SimplifyIfReturnBoolRector/Fixture/skip_same_bool_return.php.inc

diff --git a/rules-tests/CodeQuality/Rector/If_/SimplifyIfReturnBoolRector/Fixture/skip_same_bool_return.php.inc b/rules-tests/CodeQuality/Rector/If_/SimplifyIfReturnBoolRector/Fixture/skip_same_bool_return.php.inc
new file mode 100644
index 00000000000..1bafd2e914c
--- /dev/null
+++ b/rules-tests/CodeQuality/Rector/If_/SimplifyIfReturnBoolRector/Fixture/skip_same_bool_return.php.inc
@@ -0,0 +1,17 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\If_\SimplifyIfReturnBoolRector\Fixture;
+
+function skipSameBoolReturnFalse(): false
+{
+    return false;
+}
+
+function skipSameBoolReturn(): bool
+{
+    if (! skipSameBoolReturnFalse()) {
+        return true;
+    }
+
+    return true;
+}
diff --git a/rules/CodeQuality/Rector/If_/SimplifyIfReturnBoolRector.php b/rules/CodeQuality/Rector/If_/SimplifyIfReturnBoolRector.php
index f0129cd4ee3..4d00e16370c 100644
--- a/rules/CodeQuality/Rector/If_/SimplifyIfReturnBoolRector.php
+++ b/rules/CodeQuality/Rector/If_/SimplifyIfReturnBoolRector.php
@@ -141,6 +141,13 @@ private function shouldSkipIfAndReturn(If_ $if, Return_ $return): bool
             return true;
         }
 
+        // both branches return the same boolean → condition is pointless, transform would be unsound
+        if ($this->valueResolver->isTrueOrFalse($return->expr) && $this->valueResolver->isTrue(
+            $returnedExpr
+        ) === $this->valueResolver->isTrue($return->expr)) {
+            return true;
+        }
+
         // negate + negate → skip for now
         if (! $this->valueResolver->isFalse($returnedExpr)) {
             return ! $this->valueResolver->isTrueOrFalse($return->expr);