Drupal as a composer based set

[bbrala]

Question

I've been working a lot on Drupal Rector lately, improving coverage for the current and last major a lot. Also we have pretty awesome (widely used) BC fixes implement. I'm pretty excited about your composer based sets. I wonder, before i start working on support, would you be willing to include Drupal in the composer based sets as an option?

If so, are there gotcha's I need to consider?

p.s. I love Rector. You rock <3

[samsonasik]

@bbrala I think you need to enable Issues tab there https://github.com/palantirnet/drupal-rector

Many drupal user just create issues directly here when found a bug on drupal-rector, see closed issues :)

https://github.com/rectorphp/rector/issues?q=is%3Aissue%20state%3Aclosed%20drupal

[bbrala]

Hehe, yeah the original creator decided to do the issues on Drupal.org, but I can easily migrate to Github since Drupal.org issues are about to move to gitlab.

That would make life a little easier.

@agentrickard would you be ok with that?

[TomasVotruba]

@bbrala Hey, thanks for working on the community rules. I've checked rule sets briefly and they look quite complete. So I'd be open to including it the composer-based sets.

If so, are there gotcha's I need to consider?

Take an inspiration from Laravel Rector integration. The important steps on your side:

• creating set provider class with all Drupal versions linked to specific configs with rule to upgrade to that version: https://github.com/calebdw/rector-laravel/blob/5ac16ee5cae43c382142ac3fd7d12f3809e43f6f/src/Set/LaravelSetProvider.php#L13
• add registration of set provider in you README: https://github.com/calebdw/rector-laravel#automate-laravel-upgrades

On our side:

• adding new SetGroup::DRUPAL - the same constant should be used in your group name const: https://github.com/calebdw/rector-laravel/blob/5ac16ee5cae43c382142ac3fd7d12f3809e43f6f/src/Set/LaravelSetProvider.php#L13

Once you setup the Rector\Set\Contract\SetProviderInterface in your main branch, even with 1-2 sets, let me know. We can kick of testing here.

[bbrala]

Awesome, thank you. Will have a look soon. Think I already made a plan for the implementation. Seemed straightforward enough. Especially excited to be able to transparently include the bc breaking rectors automatically for people using drupal rector on their site.

[samsonasik]

@TomasVotruba @bbrala rector-laravel main repo is on https://github.com/driftingly/rector-laravel

[bbrala]

Just to be sure, you need this change in main before we can start off testing right? If so, i will need to update the readme before and after merge since it would confuse users :)

[TomasVotruba]

We can add it to dev-main so you can test it 👍

[bbrala]

I don't mind merging, but would perhaps be helpfull to have a sanity check from the rector perspective on palantirnet/drupal-rector#370. Would be greatly appreciated.

[TomasVotruba]

@bbrala I've shared few comments 👍

[bbrala]

Merged, and made a PR on src :)

[bbrala]

Things do seem to work correctly, i added a last fix in palantirnet/drupal-rector#373 since we dont need backward compatible fixes enabled when using composer based sets.

I did mention i tested a few client projects in the PR on src, so that seems good. I'll try and get some other to do the same so we have a little more spread.