feature: dont confirm connecting to ws without proj (#23867)

[adietish]

fixes eclipse-che/che#23867

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 87760112-919d-4cf6-9152-72d0a435ff5d

📥 Commits

Reviewing files that changed from the base of the PR and between 9f7b425 and 2f9d4f0.

📒 Files selected for processing (2)

• src/main/kotlin/com/redhat/devtools/gateway/server/RemoteIDEServerStatus.kt
• src/main/kotlin/com/redhat/devtools/gateway/view/steps/DevSpacesWorkspacesStepView.kt

💤 Files with no reviewable changes (2)

• src/main/kotlin/com/redhat/devtools/gateway/view/steps/DevSpacesWorkspacesStepView.kt
• src/main/kotlin/com/redhat/devtools/gateway/server/RemoteIDEServerStatus.kt

---

📝 Walkthrough

Summary by CodeRabbit

Release Notes

• Bug Fixes
  • Removed redundant confirmation dialog during DevSpaces workspace connections, streamlining the user experience.
  • Improved workspace readiness detection for more accurate connection status.

Walkthrough

The PR refactors workspace readiness semantics by replacing the hasProject check with isReady in the status model, and removes the associated user confirmation dialog from the workspace connection flow. Readiness now depends on joinLink availability rather than project existence.

Changes

Workspace Readiness Check Refactoring

Layer / File(s)	Summary
Readiness property in RemoteIDEServerStatus src/main/kotlin/com/redhat/devtools/gateway/server/RemoteIDEServerStatus.kt	hasProject getter (checking projects non-empty) is removed and replaced with isReady getter (checking joinLink non-null and non-blank).
Workspace connection simplification in DevSpacesWorkspacesStepView src/main/kotlin/com/redhat/devtools/gateway/view/steps/DevSpacesWorkspacesStepView.kt	onNext() removes the confirmation dialog that previously blocked when !serverStatus.hasProject, allowing direct connection to proceed.

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	No description was provided by the author, making it impossible to assess whether it relates to the changeset.	Add a pull request description explaining the motivation, changes, and any relevant context for removing the confirmation dialog.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: removing a confirmation dialog when connecting to a workspace without a project.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 22.23%. Comparing base (71098f6) to head (2f9d4f0).
⚠️ Report is 351 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##            main     #312       +/-   ##
==========================================
+ Coverage   0.00%   22.23%   +22.23%     
==========================================
  Files          4       99       +95     
  Lines         26     4215     +4189     
  Branches       0      769      +769     
==========================================
+ Hits           0      937      +937     
- Misses        26     3159     +3133     
- Partials       0      119      +119     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.