fix: improve profile resolution for explicit cloud/enterprise commands (#353)

- Replace generic default_profile with type-specific defaults (default_enterprise, default_cloud)
- Add resolve_enterprise_profile() and resolve_cloud_profile() helper methods
- Update ConnectionManager to use type-specific resolution
- Replace Default profile command with DefaultEnterprise and DefaultCloud
- Resolution priority: explicit flag > type-specific default > first profile of matching type > error
- Add comprehensive tests for profile resolution logic

Fixes #350

Author: joshrotenberg

crates/redisctl/src/cli.rs

@@ -210,10 +210,17 @@ pub enum ProfileCommands {
         name: String,
     },
 
-    /// Set the default profile
-    #[command(visible_alias = "def")]
-    Default {
-        /// Profile name to set as default
+    /// Set the default profile for enterprise commands
+    #[command(name = "default-enterprise", visible_alias = "def-ent")]
+    DefaultEnterprise {
+        /// Profile name to set as default for enterprise commands
+        name: String,
+    },
+
+    /// Set the default profile for cloud commands
+    #[command(name = "default-cloud", visible_alias = "def-cloud")]
+    DefaultCloud {
+        /// Profile name to set as default for cloud commands
         name: String,
     },
 }

crates/redisctl/src/commands/cloud/cloud_account.rs

@@ -2,7 +2,6 @@
 
 use crate::cli::{CloudProviderAccountCommands, OutputFormat};
 use crate::commands::cloud::cloud_account_impl::{self, CloudAccountOperationParams};
-use crate::commands::cloud::utils::create_cloud_client_raw;
 use crate::connection::ConnectionManager;
 use crate::error::Result as CliResult;
 
@@ -13,8 +12,7 @@ pub async fn handle_cloud_account_command(
     output_format: OutputFormat,
     query: Option<&str>,
 ) -> CliResult<()> {
-    let profile = conn_mgr.get_profile(profile_name)?;
-    let client = create_cloud_client_raw(profile).await?;
+    let client = conn_mgr.create_cloud_client(profile_name).await?;
 
     match command {
         CloudProviderAccountCommands::List => {

crates/redisctl/src/commands/cloud/connectivity/vpc_peering.rs

@@ -22,8 +22,7 @@ pub async fn handle_vpc_peering_command(
     output_format: OutputFormat,
     query: Option<&str>,
 ) -> CliResult<()> {
-    let profile = conn_mgr.get_profile(profile_name)?;
-    let client = crate::commands::cloud::utils::create_cloud_client_raw(profile).await?;
+    let client = conn_mgr.create_cloud_client(profile_name).await?;
 
     match command {
         VpcPeeringCommands::Get { subscription } => {

crates/redisctl/src/commands/cloud/utils.rs

@@ -3,7 +3,6 @@
 use anyhow::Context;
 use chrono::{DateTime, Utc};
 use colored::Colorize;
-use redis_cloud::CloudClient;
 use serde_json::Value;
 use std::fs;
 use std::io::{self, Write};
@@ -13,7 +12,7 @@ use tabled::Tabled;
 use std::io::IsTerminal;
 
 use crate::cli::OutputFormat;
-use crate::config::Profile;
+
 use crate::error::{RedisCtlError, Result as CliResult};
 use crate::output::print_output;
 
@@ -253,30 +252,6 @@ pub fn confirm_action(message: &str) -> CliResult<bool> {
     Ok(input.trim().eq_ignore_ascii_case("y") || input.trim().eq_ignore_ascii_case("yes"))
 }
 
-/// Create a raw cloud client from profile
-pub async fn create_cloud_client_raw(profile: &Profile) -> CliResult<CloudClient> {
-    match &profile.credentials {
-        crate::config::ProfileCredentials::Cloud {
-            api_key,
-            api_secret,
-            api_url,
-        } => {
-            let client = redis_cloud::client::CloudClientBuilder::new()
-                .api_key(api_key.clone())
-                .api_secret(api_secret.clone())
-                .base_url(api_url.clone())
-                .build()
-                .map_err(|e| {
-                    RedisCtlError::Configuration(format!("Failed to create cloud client: {}", e))
-                })?;
-            Ok(client)
-        }
-        _ => Err(RedisCtlError::Configuration(
-            "Profile is not configured for Cloud deployment".to_string(),
-        )),
-    }
-}
-
 /// Read file input, supporting @filename notation
 pub fn read_file_input(input: &str) -> CliResult<String> {
     if let Some(filename) = input.strip_prefix('@') {