Skip to content

Commit 3d4273f

Browse files
Merge pull request #25 from joshrotenberg/feat/use-typed-apis
feat: migrate commands to use typed APIs for dogfooding
2 parents 1948f82 + 97532ec commit 3d4273f

File tree

14 files changed

+491
-755
lines changed

14 files changed

+491
-755
lines changed

CLAUDE.md

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ This file provides guidance to Claude Code (claude.ai/code) when working with co
1212
```
1313
redisctl/
1414
├── crates/
15-
│ ├── redis-common/ # Shared utilities (config, output, errors)
1615
│ ├── redis-cloud/ # Cloud API client library
1716
│ ├── redis-enterprise/ # Enterprise API client library
1817
│ └── redisctl/ # Unified CLI application
@@ -22,9 +21,8 @@ redisctl/
2221
```
2322

2423
### Key Components
25-
- **redis-common**: Shared utilities for config, output formatting (JSON/YAML/Table), JMESPath queries, errors
26-
- **redis-cloud**: Cloud API client with handlers for subscriptions, databases, users, backups, ACLs, peering
27-
- **redis-enterprise**: Enterprise API client with handlers for clusters, bdbs, nodes, users, modules, stats
24+
- **redis-cloud**: Cloud API client with handlers for subscriptions, databases, users, backups, ACLs, peering (100% test coverage)
25+
- **redis-enterprise**: Enterprise API client with handlers for clusters, bdbs, nodes, users, modules, stats (100% test coverage)
2826
- **redisctl**: Main CLI with smart routing logic in `router.rs`, profile management, deployment detection
2927

3028
### CLI Architecture (Three-Tier Design)

README.md

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,6 @@ redisctl/
169169
├── crates/
170170
│ ├── redis-cloud/ # Cloud API client library
171171
│ ├── redis-enterprise/ # Enterprise API client library
172-
│ ├── redis-common/ # Shared utilities
173172
│ └── redisctl/ # Unified CLI application
174173
├── docs/ # Documentation (mdBook)
175174
├── tests/ # Integration tests
@@ -189,12 +188,6 @@ redisctl/
189188
- Support for cluster management, CRDB, modules
190189
- Bootstrap and initialization workflows
191190

192-
- **redis-common** - Shared utilities
193-
- Configuration and profile management
194-
- Output formatting (JSON, YAML, Table)
195-
- JMESPath query engine
196-
- Error handling
197-
198191
#### CLI Application
199192
- **redisctl** - Unified command-line interface
200193
- Smart command routing
@@ -298,7 +291,6 @@ Add to your `Cargo.toml`:
298291
[dependencies]
299292
redis-cloud = "0.1.0" # For Cloud API
300293
redis-enterprise = "0.1.0" # For Enterprise API
301-
redis-common = "0.1.0" # For shared utilities
302294
```
303295

304296
Example usage:

crates/redis-common/CHANGELOG.md

Lines changed: 0 additions & 5 deletions
This file was deleted.

crates/redis-common/Cargo.toml

Lines changed: 0 additions & 27 deletions
This file was deleted.

crates/redis-common/src/config.rs

Lines changed: 0 additions & 121 deletions
This file was deleted.

crates/redis-common/src/error.rs

Lines changed: 0 additions & 57 deletions
This file was deleted.

crates/redis-common/src/lib.rs

Lines changed: 0 additions & 7 deletions
This file was deleted.

crates/redis-common/src/output.rs

Lines changed: 0 additions & 113 deletions
This file was deleted.

0 commit comments

Comments
 (0)