From cb4055d428ed9432b2846f029eb200938415e1f5 Mon Sep 17 00:00:00 2001 From: Josh Rotenberg Date: Thu, 18 Dec 2025 21:17:19 -0800 Subject: [PATCH] fix(ci): extract version from tag for Homebrew formula update The mislav/bump-homebrew-formula-action compares formula version against the tag-name to determine if an update is needed. With our tag format 'redisctl-v0.7.3', the action was comparing '0.7.2' (from formula) against 'redisctl-v0.7.3' and incorrectly determining that 0.7.2 is newer. This fix extracts just the version number (e.g., '0.7.3') from the full tag name and passes 'v0.7.3' to the action for proper comparison, while keeping the original tag for the download URL. --- .github/workflows/release.yml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 0b421ff..b5996a5 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -289,12 +289,18 @@ jobs: if: ${{ always() && needs.host.result == 'success' && startsWith(needs.plan.outputs.tag, 'redisctl-v') }} runs-on: "ubuntu-22.04" steps: + - name: Extract version from tag + id: version + run: | + TAG="${{ needs.plan.outputs.tag }}" + VERSION="${TAG#redisctl-v}" + echo "version=$VERSION" >> $GITHUB_OUTPUT - uses: mislav/bump-homebrew-formula-action@v3.2 with: formula-name: redisctl formula-path: Formula/redisctl.rb base-branch: main - tag-name: ${{ needs.plan.outputs.tag }} + tag-name: v${{ steps.version.outputs.version }} homebrew-tap: redis-developer/homebrew-tap download-url: "https://github.com/redis-developer/redisctl/releases/download/${{ needs.plan.outputs.tag }}/redisctl-x86_64-apple-darwin.tar.xz" env: