Skip to content

Commit 949d9ee

Browse files
author
jruaux
committed
test: Fixed redis enterprise tests
1 parent 1c3d161 commit 949d9ee

File tree

6 files changed

+4
-19
lines changed

6 files changed

+4
-19
lines changed

core/redis-enterprise-admin/redis-enterprise-admin.gradle

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ dependencies {
33
implementation 'org.apache.httpcomponents.client5:httpclient5'
44
implementation 'org.springframework:spring-core'
55
implementation 'org.awaitility:awaitility'
6+
testImplementation 'org.slf4j:slf4j-simple'
67
testImplementation 'org.junit.jupiter:junit-jupiter-api'
78
testImplementation 'org.junit.jupiter:junit-jupiter-params'
89
testImplementation 'org.junit.jupiter:junit-jupiter-engine'

core/redis-enterprise-admin/src/main/java/com/redis/enterprise/Admin.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,6 @@
4040
import org.apache.hc.core5.http.io.entity.StringEntity;
4141
import org.apache.hc.core5.ssl.SSLContexts;
4242
import org.awaitility.Awaitility;
43-
import org.slf4j.Logger;
44-
import org.slf4j.LoggerFactory;
4543

4644
import com.fasterxml.jackson.databind.DeserializationFeature;
4745
import com.fasterxml.jackson.databind.JavaType;
@@ -54,8 +52,6 @@
5452

5553
public class Admin implements AutoCloseable {
5654

57-
private static final Logger log = LoggerFactory.getLogger(Admin.class);
58-
5955
public static final String DEFAULT_USER_NAME = "admin@redis.com";
6056
public static final String DEFAULT_PASSWORD = "redis123";
6157
public static final String DEFAULT_PROTOCOL = "https";
@@ -177,7 +173,6 @@ private <T> T post(String path, Object request, JavaType responseType)
177173
throws IOException, GeneralSecurityException {
178174
HttpPost post = new HttpPost(uri(path));
179175
String json = objectMapper.writeValueAsString(request);
180-
log.debug("POST {}", json);
181176
post.setEntity(new StringEntity(json));
182177
return read(header(post), responseType, HttpStatus.SC_OK);
183178
}
@@ -259,7 +254,6 @@ public void deleteDatabase(long uid) {
259254
return true;
260255
} catch (HttpResponseException e) {
261256
if (e.getStatusCode() == HttpStatus.SC_CONFLICT) {
262-
log.info("Could not delete database {}, retrying...", uid);
263257
return false;
264258
}
265259
throw e;

core/redis-enterprise-admin/src/test/java/com/redis/enterprise/AbstractTestBase.java

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,6 @@
33
import java.io.IOException;
44
import java.security.GeneralSecurityException;
55
import java.util.List;
6-
import java.util.logging.Level;
7-
import java.util.logging.Logger;
8-
import java.util.stream.Collectors;
96
import java.util.stream.Stream;
107

118
import org.apache.hc.client5.http.HttpResponseException;
@@ -27,8 +24,6 @@
2724
@TestInstance(Lifecycle.PER_CLASS)
2825
abstract class AbstractTestBase {
2926

30-
private static final Logger log = Logger.getLogger(AbstractTestBase.class.getName());
31-
3227
protected Admin admin;
3328

3429
@BeforeAll
@@ -46,8 +41,6 @@ void teardownAdmin() throws Exception {
4641
@BeforeEach
4742
void deleteAllDatabases() throws GeneralSecurityException, IOException, ParseException {
4843
List<Database> databases = admin.getDatabases();
49-
log.log(Level.INFO, "Deleting databases {0}",
50-
databases.stream().map(Database::getUid).collect(Collectors.toList()));
5144
for (Database database : databases) {
5245
admin.deleteDatabase(database.getUid());
5346
}
@@ -98,7 +91,7 @@ void deleteDatabase() throws ParseException, GeneralSecurityException, IOExcepti
9891
@Test
9992
void createDatabaseException() throws ParseException, IOException {
10093
Assertions.assertThrows(HttpResponseException.class, () -> admin.createDatabase(
101-
Database.builder().name("DatabaseCreateExceptionTestDB").memory(DataSize.ofGigabytes(10)).build()));
94+
Database.builder().name("DatabaseCreateExceptionTestDB").memory(DataSize.ofGigabytes(999)).build()));
10295
}
10396

10497
}

core/redis-enterprise-admin/src/test/java/com/redis/enterprise/RedisEnterpriseServerTests.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,11 @@
33
import org.junit.jupiter.api.condition.EnabledOnOs;
44
import org.junit.jupiter.api.condition.OS;
55

6-
@EnabledOnOs(value = OS.MAC)
76
class RedisEnterpriseServerTests extends AbstractTestBase {
87

98
@Override
109
protected Admin admin() {
11-
Admin admin = new Admin();
12-
admin.withHost("nuc");
13-
return admin;
10+
return new Admin();
1411
}
1512

1613
}
Binary file not shown.

gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ springBootVersion = 3.2.2
88

99
jacocoVersion = 0.8.11
1010
lettucemodVersion = 3.7.3
11-
testcontainersRedisVersion = 2.0.3-SNAPSHOT
11+
testcontainersRedisVersion = 2.0.2
1212

1313
org.gradle.daemon = false
1414
org.gradle.caching = false

0 commit comments

Comments
 (0)