Skip to content

Commit 3fd37de

Browse files
committed
Upgraded dependencies and removed Lombok
1 parent daec655 commit 3fd37de

File tree

4 files changed

+152
-44
lines changed

4 files changed

+152
-44
lines changed

jreleaser.yml

Lines changed: 36 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,24 @@ project:
1111

1212
release:
1313
github:
14-
username: jruaux
1514
overwrite: true
15+
sign: true
1616
changelog:
17-
contributors:
18-
enabled: false
19-
sort: DESC
2017
formatted: ALWAYS
2118
format: '- {{commitShortHash}} {{commitTitle}}'
19+
contributors:
20+
enabled: false
2221
labelers:
22+
- label: 'merge_pull'
23+
title: 'Merge pull'
24+
- label: 'merge_branch'
25+
title: 'Merge branch'
26+
- label: 'translation'
27+
title: '[translation]'
28+
- label: 'task'
29+
title: '[chore]'
30+
- label: 'dependencies'
31+
title: '[deps]'
2332
- label: 'feature'
2433
title: 'Resolves #'
2534
body: 'Resolves #'
@@ -29,11 +38,11 @@ release:
2938
- label: 'issue'
3039
title: 'Relates to #'
3140
body: 'Relates to #'
32-
- label: 'task'
33-
title: '[chore]'
34-
- label: 'dependencies'
35-
title: '[deps]'
3641
categories:
42+
- title: 'Merge'
43+
labels:
44+
- 'merge_pull'
45+
- 'merge_branch'
3746
- title: '🚀 Features'
3847
labels:
3948
- 'feature'
@@ -43,14 +52,29 @@ release:
4352
- title: '🧰 Tasks'
4453
labels:
4554
- 'task'
46-
- title: '⚙️ Dependencies'
55+
- title: '🌐 Translation'
56+
labels:
57+
- 'translation'
58+
- title: '⚙️ Dependencies'
4759
labels:
4860
- 'dependencies'
61+
hide:
62+
categories:
63+
- 'Merge'
64+
contributors:
65+
- 'GitHub'
4966
replacers:
5067
- search: '\[chore\] '
51-
replace: ''
5268
- search: '\[deps\] '
53-
replace: ''
69+
- search: '\[translation\] '
70+
71+
signing:
72+
active: always
73+
armored: true
74+
files: false
75+
76+
checksum:
77+
files: false
5478

5579
announce:
5680
slack:
@@ -69,6 +93,7 @@ distributions:
6993
artifacts:
7094
- path: target/components/packages/{{distributionName}}.{{projectVersion}}.zip
7195
transform: '{{distributionName}}.{{projectEffectiveVersion}}.zip'
96+
7297
files:
7398
artifacts:
7499
- path: target/generated-docs/redis-enterprise-kafka-{{projectVersion}}.pdf

pom.xml

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,11 @@
2626
<jruby.version>9.2.17.0</jruby.version>
2727
<junit.version>5.8.1</junit.version>
2828
<lettucemod.version>1.8.1</lettucemod.version>
29-
<lombok.version>1.18.22</lombok.version>
3029
<mockito.version>4.1.0</mockito.version>
31-
<reactor.version>3.4.12</reactor.version>
32-
<spring-batch-redis.version>2.23.7</spring-batch-redis.version>
33-
<slf4j.version>1.7.30</slf4j.version>
30+
<reactor.version>3.4.13</reactor.version>
31+
<spring-batch-redis.version>2.23.9</spring-batch-redis.version>
32+
<spring-batch.version>4.3.4</spring-batch.version>
33+
<slf4j.version>1.7.32</slf4j.version>
3434
<testcontainers-redis.version>1.4.6</testcontainers-redis.version>
3535
<testcontainers.version>1.15.3</testcontainers.version>
3636
<component-owner>redis</component-owner>
@@ -98,20 +98,19 @@
9898
</dependency>
9999
<dependency>
100100
<groupId>com.redis</groupId>
101-
<artifactId>spring-boot-starter-batch-redis</artifactId>
101+
<artifactId>spring-batch-redis</artifactId>
102102
<version>${spring-batch-redis.version}</version>
103103
</dependency>
104+
<dependency>
105+
<groupId>org.springframework.batch</groupId>
106+
<artifactId>spring-batch-core</artifactId>
107+
<version>${spring-batch.version}</version>
108+
</dependency>
104109
<dependency>
105110
<groupId>org.slf4j</groupId>
106111
<artifactId>slf4j-simple</artifactId>
107112
<version>${slf4j.version}</version>
108113
</dependency>
109-
<dependency>
110-
<groupId>org.projectlombok</groupId>
111-
<artifactId>lombok</artifactId>
112-
<version>${lombok.version}</version>
113-
<scope>test</scope>
114-
</dependency>
115114
<dependency>
116115
<groupId>com.github.jcustenborder.kafka.connect</groupId>
117116
<artifactId>connect-utils-testing</artifactId>
@@ -199,7 +198,7 @@
199198
<plugin>
200199
<groupId>org.jacoco</groupId>
201200
<artifactId>jacoco-maven-plugin</artifactId>
202-
<version>0.8.6</version>
201+
<version>0.8.7</version>
203202
</plugin>
204203
<plugin>
205204
<groupId>org.apache.maven.plugins</groupId>

src/test/integration/java/com/redis/kafka/connect/RedisEnterpriseSinkTaskIT.java

Lines changed: 101 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,6 @@
4949
import io.lettuce.core.Range;
5050
import io.lettuce.core.ScoredValue;
5151
import io.lettuce.core.StreamMessage;
52-
import lombok.Builder;
53-
import lombok.Data;
54-
import lombok.Singular;
5552

5653
class RedisEnterpriseSinkTaskIT extends AbstractTestcontainersRedisTestBase {
5754

@@ -130,39 +127,125 @@ void putHash(RedisTestContext redis) {
130127
}
131128
}
132129

133-
@Data
134-
@Builder
135130
private static class Person {
136131
private long id;
137132
private String name;
138-
@Singular
139-
private Set<String> hobbies;
133+
private Set<String> hobbies = new HashSet<>();
140134
private Address address;
135+
136+
public long getId() {
137+
return id;
138+
}
139+
140+
public void setId(long id) {
141+
this.id = id;
142+
}
143+
144+
public String getName() {
145+
return name;
146+
}
147+
148+
public void setName(String name) {
149+
this.name = name;
150+
}
151+
152+
public Set<String> getHobbies() {
153+
return hobbies;
154+
}
155+
156+
public void setHobbies(Set<String> hobbies) {
157+
this.hobbies = hobbies;
158+
}
159+
160+
public Address getAddress() {
161+
return address;
162+
}
163+
164+
public void setAddress(Address address) {
165+
this.address = address;
166+
}
167+
141168
}
142169

143-
@Data
144-
@Builder
145170
private static class Address {
171+
146172
private String street;
147173
private String city;
148174
private String state;
149175
private String zip;
176+
177+
public String getStreet() {
178+
return street;
179+
}
180+
181+
public void setStreet(String street) {
182+
this.street = street;
183+
}
184+
185+
public String getCity() {
186+
return city;
187+
}
188+
189+
public void setCity(String city) {
190+
this.city = city;
191+
}
192+
193+
public String getState() {
194+
return state;
195+
}
196+
197+
public void setState(String state) {
198+
this.state = state;
199+
}
200+
201+
public String getZip() {
202+
return zip;
203+
}
204+
205+
public void setZip(String zip) {
206+
this.zip = zip;
207+
}
208+
150209
}
151210

152211
@ParameterizedTest
153212
@RedisTestContextsSource
154213
void putJSON(RedisTestContext redis) throws JsonProcessingException {
155214
String topic = "putJSON";
156215
List<Person> persons = new ArrayList<>();
157-
persons.add(Person.builder().id(1).name("Bodysnatch Cummerbund")
158-
.address(Address.builder().city("New York").zip("10013").state("NY").street("150 Mott St").build())
159-
.hobby("Fishing").hobby("Singing").build());
160-
persons.add(Person.builder().id(2).name("Buffalo Custardbath").address(
161-
Address.builder().city("Los Angeles").zip("90001").state("CA").street("123 Sunset Blvd").build())
162-
.hobby("Surfing").hobby("Piano").build());
163-
persons.add(Person.builder().id(3).name("Bumblesnuff Crimpysnitch")
164-
.address(Address.builder().city("Chicago").zip("60603").state("IL").street("100 S State St").build())
165-
.hobby("Skiing").hobby("Drums").build());
216+
Person person1 = new Person();
217+
person1.setId(1);
218+
person1.setName("Bodysnitch Canderbunt");
219+
person1.setHobbies(new HashSet<>(Arrays.asList("Fishing", "Singing")));
220+
Address address1 = new Address();
221+
address1.setCity("New York");
222+
address1.setZip("10013");
223+
address1.setState("NY");
224+
address1.setStreet("150 Mott St");
225+
person1.setAddress(address1);
226+
persons.add(person1);
227+
Person person2 = new Person();
228+
person2.setId(2);
229+
person2.setName("Buffalo Custardbath");
230+
person2.setHobbies(new HashSet<>(Arrays.asList("Surfing", "Piano")));
231+
Address address2 = new Address();
232+
address2.setCity("Los Angeles");
233+
address2.setZip("90001");
234+
address2.setState("CA");
235+
address2.setStreet("123 Sunset Blvd");
236+
person2.setAddress(address2);
237+
persons.add(person2);
238+
Person person3 = new Person();
239+
person3.setId(3);
240+
person3.setName("Bumblesnuff Crimpysnitch");
241+
person3.setHobbies(new HashSet<>(Arrays.asList("Skiing", "Drums")));
242+
Address address3 = new Address();
243+
address3.setCity("Chicago");
244+
address3.setZip("60603");
245+
address3.setState("IL");
246+
address3.setStreet("100 S State St");
247+
person3.setAddress(address3);
248+
persons.add(person3);
166249
List<SinkRecord> records = new ArrayList<>();
167250
ObjectMapper mapper = new ObjectMapper();
168251
for (Person person : persons) {

src/test/integration/java/com/redis/kafka/connect/RedisEnterpriseSourceTaskIT.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@
1414
import org.junit.jupiter.api.Assertions;
1515
import org.junit.jupiter.api.BeforeEach;
1616
import org.junit.jupiter.params.ParameterizedTest;
17+
import org.slf4j.Logger;
18+
import org.slf4j.LoggerFactory;
1719
import org.springframework.util.Assert;
1820
import org.testcontainers.junit.jupiter.Container;
1921

@@ -28,11 +30,10 @@
2830
import com.redis.testcontainers.junit.jupiter.RedisTestContext;
2931
import com.redis.testcontainers.junit.jupiter.RedisTestContextsSource;
3032

31-
import lombok.extern.slf4j.Slf4j;
32-
33-
@Slf4j
3433
class RedisEnterpriseSourceTaskIT extends AbstractTestcontainersRedisTestBase {
3534

35+
private static final Logger log = LoggerFactory.getLogger(RedisEnterpriseSourceTaskIT.class);
36+
3637
@Container
3738
private static final RedisContainer REDIS = new RedisContainer(
3839
RedisContainer.DEFAULT_IMAGE_NAME.withTag(RedisContainer.DEFAULT_TAG)).withKeyspaceNotifications();

0 commit comments

Comments
 (0)