From b288c14ea44ece3577a1874754fdd5c176122a9f Mon Sep 17 00:00:00 2001 From: Andre Cowie <10882435+andrecowie@users.noreply.github.com> Date: Thu, 29 May 2025 12:35:49 +1000 Subject: [PATCH 1/3] Making a change to make null's call the conditional del. --- .../main/java/com/redis/kafka/connect/sink/RedisSinkTask.java | 3 +++ gradle.properties | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/core/redis-kafka-connect/src/main/java/com/redis/kafka/connect/sink/RedisSinkTask.java b/core/redis-kafka-connect/src/main/java/com/redis/kafka/connect/sink/RedisSinkTask.java index b62433a..347ba3f 100644 --- a/core/redis-kafka-connect/src/main/java/com/redis/kafka/connect/sink/RedisSinkTask.java +++ b/core/redis-kafka-connect/src/main/java/com/redis/kafka/connect/sink/RedisSinkTask.java @@ -310,6 +310,9 @@ private Collection> streamMessages(SinkRecord sink @SuppressWarnings("unchecked") private Map map(SinkRecord sinkRecord) { Object value = sinkRecord.value(); + if (value == null) { + return Collections.emptyMap(); + } if (value instanceof Struct) { Map body = new LinkedHashMap<>(); Struct struct = (Struct) value; diff --git a/gradle.properties b/gradle.properties index e64ec69..7570552 100644 --- a/gradle.properties +++ b/gradle.properties @@ -16,8 +16,8 @@ # limitations under the License. # group = com.redis -sourceCompatibility = 17 -targetCompatibility = 17 +sourceCompatibility = 21 +targetCompatibility = 21 reproducibleBuild = true asciidoctorVersion = 3.3.2 From cdbfe559113135a158695301a61ccd9a25d151aa Mon Sep 17 00:00:00 2001 From: Andre Cowie <10882435+andrecowie@users.noreply.github.com> Date: Sat, 19 Jul 2025 08:58:37 +1000 Subject: [PATCH 2/3] Adding value == null return emptyMap --- .../main/java/com/redis/kafka/connect/sink/RedisSinkTask.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/core/redis-kafka-connect/src/main/java/com/redis/kafka/connect/sink/RedisSinkTask.java b/core/redis-kafka-connect/src/main/java/com/redis/kafka/connect/sink/RedisSinkTask.java index 229b769..882020e 100644 --- a/core/redis-kafka-connect/src/main/java/com/redis/kafka/connect/sink/RedisSinkTask.java +++ b/core/redis-kafka-connect/src/main/java/com/redis/kafka/connect/sink/RedisSinkTask.java @@ -335,8 +335,8 @@ private Map map(SinkRecord sinkRecord) { return body; } if (value == null) { - return Collections.emptyMap(); - } + return Collections.emptyMap(); + } throw new ConnectException("Unsupported source value type: " + sinkRecord.valueSchema().type().name()); } From 9b3dee48d5d92bf49eb76ef8451a5934630c659c Mon Sep 17 00:00:00 2001 From: Andre Cowie <10882435+andrecowie@users.noreply.github.com> Date: Sat, 19 Jul 2025 09:00:03 +1000 Subject: [PATCH 3/3] REVERT 21 TO 17 --- gradle.properties | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gradle.properties b/gradle.properties index 7570552..d50ca67 100644 --- a/gradle.properties +++ b/gradle.properties @@ -16,8 +16,8 @@ # limitations under the License. # group = com.redis -sourceCompatibility = 21 -targetCompatibility = 21 +sourceCompatibility = 17 +targetCompatibility = 17 reproducibleBuild = true asciidoctorVersion = 3.3.2 @@ -38,4 +38,4 @@ org.gradle.daemon = false org.gradle.caching = false org.gradle.parallel = false systemProp.file.encoding = utf-8 -org.gradle.jvmargs = -Dfile.encoding=UTF-8 \ No newline at end of file +org.gradle.jvmargs = -Dfile.encoding=UTF-8