Skip to content

Commit 0ff533c

Browse files
committed
Added getContext to test base
1 parent 53e91d8 commit 0ff533c

File tree

11 files changed

+28
-32
lines changed

11 files changed

+28
-32
lines changed

gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,6 @@ kordampBuildVersion=2.6.0
55

66
awaitilityVersion=4.1.1
77
junitVersion=5.7.2
8-
lettucemodVersion=1.7.3
8+
lettucemodVersion=1.8.0
99
slf4jVersion=1.7.32
1010
testcontainersVersion=1.15.3

subprojects/testcontainers-redis-junit-jupiter/src/main/java/com/redis/testcontainers/junit/jupiter/AbstractTestcontainersRedisTestBase.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,10 @@ public abstract class AbstractTestcontainersRedisTestBase {
3535

3636
protected abstract Collection<RedisServer> servers();
3737

38+
protected RedisTestContext getContext(RedisServer server) {
39+
return contexts.get(server);
40+
}
41+
3842
protected Collection<RedisServer> testServers() {
3943
return servers();
4044
}

subprojects/testcontainers-redis-junit-jupiter/src/main/java/com/redis/testcontainers/junit/jupiter/RedisTestContext.java

Lines changed: 18 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -16,32 +16,28 @@
1616
public class RedisTestContext implements AutoCloseable {
1717

1818
private final RedisServer server;
19-
private final AbstractRedisClient client;
19+
private AbstractRedisClient client;
2020
private StatefulRedisModulesConnection<String, String> connection;
2121
private StatefulRedisPubSubConnection<String, String> pubSubConnection;
2222

2323
public RedisTestContext(RedisServer server) {
2424
this.server = server;
25-
this.client = client(server);
2625
}
2726

2827
@Override
2928
public String toString() {
3029
return server.toString();
3130
}
3231

33-
private AbstractRedisClient client(RedisServer server) {
34-
if (server.isCluster()) {
35-
return RedisModulesClusterClient.create(server.getRedisURI());
36-
}
37-
return RedisModulesClient.create(server.getRedisURI());
38-
}
39-
4032
public RedisServer getServer() {
4133
return server;
4234
}
4335

4436
public AbstractRedisClient getClient() {
37+
if (client == null) {
38+
this.client = server.isCluster() ? RedisModulesClusterClient.create(server.getRedisURI())
39+
: RedisModulesClient.create(server.getRedisURI());
40+
}
4541
return client;
4642
}
4743

@@ -60,17 +56,17 @@ public StatefulRedisPubSubConnection<String, String> getPubSubConnection() {
6056
}
6157

6258
private StatefulRedisModulesConnection<String, String> connection() {
63-
if (client instanceof RedisModulesClusterClient) {
64-
return ((RedisModulesClusterClient) client).connect();
59+
if (server.isCluster()) {
60+
return ((RedisModulesClusterClient) getClient()).connect();
6561
}
66-
return ((RedisModulesClient) client).connect();
62+
return ((RedisModulesClient) getClient()).connect();
6763
}
6864

6965
private StatefulRedisPubSubConnection<String, String> pubSubConnection() {
70-
if (client instanceof RedisModulesClusterClient) {
71-
return ((RedisModulesClusterClient) client).connectPubSub();
66+
if (server.isCluster()) {
67+
return ((RedisModulesClusterClient) getClient()).connectPubSub();
7268
}
73-
return ((RedisModulesClient) client).connectPubSub();
69+
return ((RedisModulesClient) getClient()).connectPubSub();
7470
}
7571

7672
public RedisModulesCommands<String, String> sync() {
@@ -93,20 +89,22 @@ public void close() {
9389
if (connection != null) {
9490
connection.close();
9591
}
96-
client.shutdown();
97-
client.getResources().shutdown();
92+
if (client != null) {
93+
client.shutdown();
94+
client.getResources().shutdown();
95+
}
9896
}
9997

10098
public RedisClient getRedisClient() {
101-
return (RedisClient) client;
99+
return (RedisClient) getClient();
102100
}
103101

104102
public RedisClusterClient getRedisClusterClient() {
105-
return (RedisClusterClient) client;
103+
return (RedisClusterClient) getClient();
106104
}
107105

108106
public boolean isCluster() {
109-
return client instanceof RedisClusterClient;
107+
return server.isCluster();
110108
}
111109

112110
}
Binary file not shown.

subprojects/testcontainers-redis-tests/bin/test/sleep.py

Lines changed: 0 additions & 6 deletions
This file was deleted.

subprojects/testcontainers-redis-tests/src/test/java/com/redis/testcontainers/test/RedisEnterpriseContainerTests.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,13 @@
77
import org.junit.jupiter.api.Test;
88

99
import com.redis.lettucemod.RedisModulesClient;
10-
import com.redis.lettucemod.Utils;
10+
import com.redis.lettucemod.RedisModulesUtils;
1111
import com.redis.lettucemod.api.StatefulRedisModulesConnection;
12-
import com.redis.lettucemod.api.search.Field;
13-
import com.redis.lettucemod.api.search.SearchResults;
1412
import com.redis.lettucemod.cluster.RedisModulesClusterClient;
1513
import com.redis.lettucemod.cluster.api.StatefulRedisModulesClusterConnection;
1614
import com.redis.lettucemod.output.ExecutionResults;
15+
import com.redis.lettucemod.search.Field;
16+
import com.redis.lettucemod.search.SearchResults;
1717
import com.redis.testcontainers.RedisEnterpriseContainer;
1818

1919
import io.lettuce.core.RedisClient;
@@ -97,7 +97,7 @@ void gears() {
9797
}
9898

9999
private String load(String resourceName) {
100-
return Utils.toString(getClass().getClassLoader().getResourceAsStream(resourceName));
100+
return RedisModulesUtils.toString(getClass().getClassLoader().getResourceAsStream(resourceName));
101101
}
102102

103103
}

0 commit comments

Comments
 (0)