Skip to content

Commit 6a59e95

Browse files
author
julien
committed
Fixed toString methods
1 parent 6951917 commit 6a59e95

File tree

6 files changed

+13
-28
lines changed

6 files changed

+13
-28
lines changed

subprojects/testcontainers-redis-junit/src/main/java/com/redis/testcontainers/junit/RedisTestContext.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,11 @@ public RedisTestContext(RedisServer server) {
2222
this.server = server;
2323
}
2424

25+
@Override
26+
public String toString() {
27+
return server.toString();
28+
}
29+
2530
public RedisServer getServer() {
2631
return server;
2732
}

subprojects/testcontainers-redis/src/main/java/com/redis/testcontainers/AbstractRedisContainer.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,4 +35,8 @@ public String toString() {
3535
return ClassUtils.getShortClassName(getClass()) + " active=" + isActive();
3636
}
3737

38+
public static boolean isActive(String envName) {
39+
return !Boolean.parseBoolean(System.getenv(envName));
40+
}
41+
3842
}

subprojects/testcontainers-redis/src/main/java/com/redis/testcontainers/RedisClusterContainer.java

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,13 @@
22

33
import java.util.Objects;
44

5-
import org.slf4j.Logger;
6-
import org.slf4j.LoggerFactory;
75
import org.testcontainers.containers.GenericContainer;
86
import org.testcontainers.containers.wait.strategy.Wait;
97
import org.testcontainers.shaded.org.apache.commons.lang.ClassUtils;
108
import org.testcontainers.utility.DockerImageName;
119

1210
public class RedisClusterContainer extends GenericContainer<RedisClusterContainer> implements RedisServer {
1311

14-
private static final Logger log = LoggerFactory.getLogger(RedisClusterContainer.class);
15-
1612
public static final DockerImageName DEFAULT_IMAGE_NAME = DockerImageName.parse("grokzen/redis-cluster");
1713
public static final String DEFAULT_TAG = "6.2.1";
1814
public static final int DEFAULT_INITIAL_PORT = 7000;
@@ -141,10 +137,7 @@ public boolean equals(Object obj) {
141137

142138
@Override
143139
public boolean isActive() {
144-
String skipValue = System.getenv(ENV_SKIP_TESTS);
145-
boolean active = !Boolean.parseBoolean(skipValue);
146-
log.info("Active: {} ({}='{}'}", active, ENV_SKIP_TESTS, skipValue);
147-
return active;
140+
return AbstractRedisContainer.isActive(ENV_SKIP_TESTS);
148141
}
149142

150143
}

subprojects/testcontainers-redis/src/main/java/com/redis/testcontainers/RedisContainer.java

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,10 @@
11
package com.redis.testcontainers;
22

3-
import org.slf4j.Logger;
4-
import org.slf4j.LoggerFactory;
53
import org.testcontainers.utility.DockerImageName;
64
import org.testcontainers.utility.MountableFile;
75

86
public class RedisContainer extends AbstractRedisContainer<RedisContainer> {
97

10-
private static final Logger log = LoggerFactory.getLogger(RedisContainer.class);
11-
128
public static final DockerImageName DEFAULT_IMAGE_NAME = DockerImageName.parse("redis");
139
public static final String DEFAULT_TAG = "6.2.6";
1410
public static final String ENV_SKIP_TESTS = "skipRedisTests";
@@ -48,10 +44,7 @@ public <C extends RedisContainer> C withKeyspaceNotifications() {
4844

4945
@Override
5046
public boolean isActive() {
51-
String skipValue = System.getenv(ENV_SKIP_TESTS);
52-
boolean active = !Boolean.parseBoolean(skipValue);
53-
log.info("Active: {} ({}='{}'}", active, ENV_SKIP_TESTS, skipValue);
54-
return active;
47+
return AbstractRedisContainer.isActive(ENV_SKIP_TESTS);
5548
}
5649

5750
}

subprojects/testcontainers-redis/src/main/java/com/redis/testcontainers/RedisEnterpriseContainer.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -225,10 +225,7 @@ public boolean equals(Object obj) {
225225

226226
@Override
227227
public boolean isActive() {
228-
String skipValue = System.getenv(ENV_SKIP_TESTS);
229-
boolean active = !Boolean.parseBoolean(skipValue);
230-
log.info("Active: {} ({}='{}'}", active, ENV_SKIP_TESTS, skipValue);
231-
return active;
228+
return AbstractRedisContainer.isActive(ENV_SKIP_TESTS);
232229
}
233230

234231
}

subprojects/testcontainers-redis/src/main/java/com/redis/testcontainers/RedisModulesContainer.java

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,9 @@
11
package com.redis.testcontainers;
22

3-
import org.slf4j.Logger;
4-
import org.slf4j.LoggerFactory;
53
import org.testcontainers.utility.DockerImageName;
64

75
public class RedisModulesContainer extends AbstractRedisContainer<RedisModulesContainer> {
86

9-
private static final Logger log = LoggerFactory.getLogger(RedisModulesContainer.class);
10-
117
public static final DockerImageName DEFAULT_IMAGE_NAME = DockerImageName.parse("redislabs/redismod");
128
public static final String DEFAULT_TAG = "latest";
139
public static final String ENV_SKIP_TESTS = "skipRedisModulesTests";
@@ -39,10 +35,7 @@ public boolean isCluster() {
3935

4036
@Override
4137
public boolean isActive() {
42-
String skipValue = System.getenv(ENV_SKIP_TESTS);
43-
boolean active = !Boolean.parseBoolean(skipValue);
44-
log.info("Active: {} ({}='{}'}", active, ENV_SKIP_TESTS, skipValue);
45-
return active;
38+
return AbstractRedisContainer.isActive(ENV_SKIP_TESTS);
4639
}
4740

4841
}

0 commit comments

Comments
 (0)