make lint happy

Author: ndyakov

maintnotifications/e2e/notification_injector.go

@@ -56,7 +56,7 @@ func NewNotificationInjector() (NotificationInjector, error) {
 	// Use proxy-based mock
 	apiPort := 8100
 	if portStr := os.Getenv("PROXY_API_PORT"); portStr != "" {
-		fmt.Sscanf(portStr, "%d", &apiPort)
+		_, _ = fmt.Sscanf(portStr, "%d", &apiPort)
 	}
 
 	return NewProxyNotificationInjector(apiPort), nil
@@ -105,7 +105,7 @@ func (p *ProxyNotificationInjector) Start() error {
 
 	targetPort := 6379
 	if portStr := os.Getenv("REDIS_TARGET_PORT"); portStr != "" {
-		fmt.Sscanf(portStr, "%d", &targetPort)
+		_, _ = fmt.Sscanf(portStr, "%d", &targetPort)
 	}
 
 	// Parse cluster addresses
@@ -116,7 +116,7 @@ func (p *ProxyNotificationInjector) Start() error {
 
 	// Extract first port for initial node
 	var initialPort int
-	fmt.Sscanf(strings.Split(addrs[0], ":")[1], "%d", &initialPort)
+	_, _ = fmt.Sscanf(strings.Split(addrs[0], ":")[1], "%d", &initialPort)
 
 	// Check if proxy is already running (e.g., in Docker)
 	proxyAlreadyRunning := false
@@ -164,7 +164,7 @@ func (p *ProxyNotificationInjector) Start() error {
 				if !proxyAlreadyRunning {
 					for i := 1; i < len(addrs); i++ {
 						var port int
-						fmt.Sscanf(strings.Split(addrs[i], ":")[1], "%d", &port)
+						_, _ = fmt.Sscanf(strings.Split(addrs[i], ":")[1], "%d", &port)
 						if err := p.addNode(port, targetPort, targetHost); err != nil {
 							return fmt.Errorf("failed to add node %d: %w", i, err)
 						}
@@ -421,7 +421,7 @@ func NewFaultInjectorNotificationInjector(baseURL string) *FaultInjectorNotifica
 
 	bdbID := 1
 	if bdbIDStr := os.Getenv("BDB_ID"); bdbIDStr != "" {
-		fmt.Sscanf(bdbIDStr, "%d", &bdbID)
+		_, _ = fmt.Sscanf(bdbIDStr, "%d", &bdbID)
 	}
 
 	return &FaultInjectorNotificationInjector{
@@ -455,9 +455,9 @@ func (f *FaultInjectorNotificationInjector) InjectSMIGRATING(ctx context.Context
 	var startSlot, endSlot int
 	if len(slots) > 0 {
 		if strings.Contains(slots[0], "-") {
-			fmt.Sscanf(slots[0], "%d-%d", &startSlot, &endSlot)
+			_, _ = fmt.Sscanf(slots[0], "%d-%d", &startSlot, &endSlot)
 		} else {
-			fmt.Sscanf(slots[0], "%d", &startSlot)
+			_, _ = fmt.Sscanf(slots[0], "%d", &startSlot)
 			endSlot = startSlot
 		}
 	}

maintnotifications/e2e/notiftracker.go

@@ -305,20 +305,6 @@ func setupClusterClientNotificationHook(client *redis.ClusterClient, hook maintn
 	})
 }
 
-// filterPushNotificationLogs filters the diagnostics log for push notification events
-func filterPushNotificationLogs(diagnosticsLog []DiagnosticsEvent) []DiagnosticsEvent {
-	var pushNotificationLogs []DiagnosticsEvent
-
-	for _, log := range diagnosticsLog {
-		switch log.Type {
-		case "MOVING", "MIGRATING", "SMIGRATING", "MIGRATED", "SMIGRATED":
-			pushNotificationLogs = append(pushNotificationLogs, log)
-		}
-	}
-
-	return pushNotificationLogs
-}
-
 func (tnh *TrackingNotificationsHook) GetAnalysis() *DiagnosticsAnalysis {
 	return NewDiagnosticsAnalysis(tnh.GetDiagnosticsLog())
 }
@@ -368,41 +354,42 @@ func NewDiagnosticsAnalysis(diagnosticsLog []DiagnosticsEvent) *DiagnosticsAnaly
 	return da
 }
 
-func (da *DiagnosticsAnalysis) Analyze() {
-	for _, log := range da.diagnosticsLog {
-		da.TotalNotifications++
+func (a *DiagnosticsAnalysis) Analyze() {
+	for _, log := range a.diagnosticsLog {
+		a.TotalNotifications++
 		switch log.Type {
 		case "MOVING":
-			da.MovingCount++
+			a.MovingCount++
 		case "MIGRATING", "SMIGRATING":
-			da.MigratingCount++
+			a.MigratingCount++
 		case "MIGRATED", "SMIGRATED":
-			da.MigratedCount++
+			a.MigratedCount++
 		case "FAILING_OVER":
-			da.FailingOverCount++
+			a.FailingOverCount++
 		case "FAILED_OVER":
-			da.FailedOverCount++
+			a.FailedOverCount++
 		default:
-			da.UnexpectedNotificationCount++
+			a.UnexpectedNotificationCount++
 		}
 		if log.Error != nil {
 			fmt.Printf("[ERROR] Notification processing error: %v\n", log.Error)
 			fmt.Printf("[ERROR] Notification: %v\n", log.Details["notification"])
 			fmt.Printf("[ERROR] Context: %v\n", log.Details["context"])
-			da.NotificationProcessingErrors++
+			a.NotificationProcessingErrors++
 		}
-		if log.Type == "MIGRATING" || log.Type == "SMIGRATING" || log.Type == "FAILING_OVER" {
-			da.RelaxedTimeoutCount++
-		} else if log.Type == "MIGRATED" || log.Type == "SMIGRATED" || log.Type == "FAILED_OVER" {
-			da.UnrelaxedTimeoutCount++
+		switch log.Type {
+		case "MIGRATING", "SMIGRATING", "FAILING_OVER":
+			a.RelaxedTimeoutCount++
+		case "MIGRATED", "SMIGRATED", "FAILED_OVER":
+			a.UnrelaxedTimeoutCount++
 		}
 		if log.ConnID != 0 {
-			if v, ok := da.connIds[log.ConnID]; !ok || !v {
-				da.connIds[log.ConnID] = true
-				da.connLogs[log.ConnID] = make([]DiagnosticsEvent, 0)
-				da.ConnectionCount++
+			if v, ok := a.connIds[log.ConnID]; !ok || !v {
+				a.connIds[log.ConnID] = true
+				a.connLogs[log.ConnID] = make([]DiagnosticsEvent, 0)
+				a.ConnectionCount++
 			}
-			da.connLogs[log.ConnID] = append(da.connLogs[log.ConnID], log)
+			a.connLogs[log.ConnID] = append(a.connLogs[log.ConnID], log)
 		}
 
 	}

maintnotifications/e2e/proxy_fault_injector_server.go

@@ -262,7 +262,7 @@ func (s *ProxyFaultInjectorServer) Stop() error {
 	if s.httpServer != nil {
 		ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second)
 		defer cancel()
-		s.httpServer.Shutdown(ctx)
+		_ = s.httpServer.Shutdown(ctx)
 	}
 
 	if s.proxyCmd != nil && s.proxyCmd.Process != nil {
@@ -332,7 +332,7 @@ func (s *ProxyFaultInjectorServer) handleListActions(w http.ResponseWriter, r *h
 	}
 
 	w.Header().Set("Content-Type", "application/json")
-	json.NewEncoder(w).Encode(actions)
+	_ = json.NewEncoder(w).Encode(actions)
 }
 
 func (s *ProxyFaultInjectorServer) handleTriggerAction(w http.ResponseWriter, r *http.Request) {
@@ -377,7 +377,7 @@ func (s *ProxyFaultInjectorServer) handleTriggerAction(w http.ResponseWriter, r
 	}
 
 	w.Header().Set("Content-Type", "application/json")
-	json.NewEncoder(w).Encode(resp)
+	_ = json.NewEncoder(w).Encode(resp)
 }
 
 func (s *ProxyFaultInjectorServer) handleActionStatus(w http.ResponseWriter, r *http.Request) {
@@ -411,7 +411,7 @@ func (s *ProxyFaultInjectorServer) handleActionStatus(w http.ResponseWriter, r *
 	}
 
 	w.Header().Set("Content-Type", "application/json")
-	json.NewEncoder(w).Encode(resp)
+	_ = json.NewEncoder(w).Encode(resp)
 }
 
 // executeAction executes an action and injects appropriate notifications