Skip to content

Commit eef7a6a

Browse files
committed
fix(ruby): app id check
1 parent c12faff commit eef7a6a

3 files changed

Lines changed: 6 additions & 13 deletions

File tree

.github/workflows/docker-publish.yaml

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,6 @@ jobs:
2929
run:
3030
name: Build and publish docker image
3131
runs-on: ubuntu-latest
32-
env:
33-
APP_SECRET: ${{ secrets.appSecret }}
34-
3532
steps:
3633
- uses: docker/login-action@v3
3734
with:
@@ -40,11 +37,11 @@ jobs:
4037
password: ${{ secrets.GITHUB_TOKEN }}
4138

4239
- id: app-token
43-
if: ${{ inputs.appId && env.APP_SECRET != '' }}
40+
if: ${{ inputs.appId }}
4441
uses: actions/create-github-app-token@v1
4542
with:
4643
app-id: ${{ inputs.appId }}
47-
private-key: ${{ env.APP_SECRET }}
44+
private-key: ${{ secrets.appSecret }}
4845
owner: ${{ github.repository_owner }}
4946

5047
- uses: actions/checkout@v5

.github/workflows/reusable-ruby-checks.yaml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,6 @@ on:
3434
jobs:
3535
run:
3636
runs-on: ubuntu-latest
37-
env:
38-
APP_SECRET: ${{ secrets.appSecret }}
3937
defaults:
4038
run:
4139
working-directory: ${{ inputs.workingDirectory }}
@@ -48,11 +46,11 @@ jobs:
4846
password: ${{ secrets.GITHUB_TOKEN }}
4947

5048
- id: app-token
51-
if: ${{ inputs.appId && env.APP_SECRET != '' }}
49+
if: ${{ inputs.appId }}
5250
uses: actions/create-github-app-token@v1
5351
with:
5452
app-id: ${{ inputs.appId }}
55-
private-key: ${{ env.APP_SECRET }}
53+
private-key: ${{ secrets.appSecret }}
5654
owner: ${{ github.repository_owner }}
5755

5856
- uses: actions/checkout@v5

.github/workflows/reusable-ruby-publish-migrated-db.yaml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,6 @@ on:
3434
jobs:
3535
run:
3636
runs-on: ubuntu-latest
37-
env:
38-
APP_SECRET: ${{ secrets.appSecret }}
3937
defaults:
4038
run:
4139
working-directory: ${{ inputs.workingDirectory }}
@@ -58,11 +56,11 @@ jobs:
5856
docker exec postgres rm -rf /docker-entrypoint-initdb.d/*
5957
6058
- id: app-token
61-
if: ${{ inputs.appId && env.APP_SECRET != '' }}
59+
if: ${{ inputs.appId }}
6260
uses: actions/create-github-app-token@v1
6361
with:
6462
app-id: ${{ inputs.appId }}
65-
private-key: ${{ env.APP_SECRET }}
63+
private-key: ${{ secrets.appSecret }}
6664
owner: ${{ github.repository_owner }}
6765

6866
- uses: actions/checkout@v5

0 commit comments

Comments
 (0)