`image$push` fails on first attempt, but works on second?

[teofiln]

Hi @richfitz,

When I am pushing an image, the first try fails with Error in log(bytes, 1000) : non-numeric argument to mathematical function.

> usr <- "myusername"
> pas <- "mypasword"
>
> d <- stevedore::docker_client()
Detected API version '1.41' is above max version '1.39'; downgrading
> imgs <- d$image$list()
> tag <- imgs$repo_tags[[1]][[2]]
> parsed <- stevedore:::parse_image_name(tag)
> 
> d$login(
+   username = usr,
+   password = pas,
+   serveraddress = parsed$repo
+ )
> d$image$push(tag)
The push refers to repository [#.dkr.ecr.us-east-1.amazonaws.com/myrepo15]
Preparing de68be92fe2a
Preparing fa5131d88951
Preparing f30e3fb3974e
Preparing 238fde637441
Preparing b3f7a8e2f3e6
Preparing b2f9b1eec67c
Preparing dba82843d679
Preparing 46028a6b91dc
Preparing 5c6224f35072
Preparing 2d244e0816c6
Preparing 6c6846419280
Preparing afb157c8a73b
Preparing d30cec5cc7ec
Waiting b2f9b1eec67c
Waiting 2d244e0816c6
Waiting dba82843d679
Waiting 46028a6b91dc
Waiting 6c6846419280
Waiting 5c6224f35072
Waiting afb157c8a73b
de68be92fe2a: Pushing 512 B/38 B 1347%
de68be92fe2a: Pushing 3.07 kB/38 B 8084%
Error in log(bytes, 1000) : non-numeric argument to mathematical function

Then, the second try, works without problem:

> d$image$push(tag)
The push refers to repository [#.dkr.ecr.us-east-1.amazonaws.com/myrepo15]
Preparing de68be92fe2a
Preparing fa5131d88951
Preparing f30e3fb3974e
Preparing 238fde637441
Preparing b3f7a8e2f3e6
Preparing b2f9b1eec67c
Preparing dba82843d679
Preparing 46028a6b91dc
Preparing 5c6224f35072
Preparing 2d244e0816c6
Preparing 6c6846419280
Preparing afb157c8a73b
Preparing d30cec5cc7ec
Waiting dba82843d679
Waiting 46028a6b91dc
Waiting 5c6224f35072
Waiting 2d244e0816c6
Waiting 6c6846419280
Waiting afb157c8a73b
Waiting d30cec5cc7ec
Waiting b2f9b1eec67c
Layer already exists de68be92fe2a
Layer already exists 238fde637441
f30e3fb3974e: Pushing 512 B/124 B 413%
f30e3fb3974e: Pushing 2.56 kB/124 B 2065%
fa5131d88951: Pushing 512 B/124 B 413%
fa5131d88951: Pushing 2.56 kB/124 B 2065%
Pushed fa5131d88951
Pushed f30e3fb3974e
b3f7a8e2f3e6: Pushing 11.99 kB/416.19 kB 3%

I poked around, but I haven't figured this out. Any pointers as to why this might be happening, or to where to look in the code would be much appreciated!

Thanks!

[teofiln]

This error likely comes down to

stevedore/R/docker_client_support.R

Line 121 in 5c281a8

pretty_bytes(cur), pretty_bytes(tot),

and then to

stevedore/R/util.R

Line 477 in 5c281a8

pretty_bytes <- function(bytes) {

. This is the only place log(bytes, 1000) is found in the code.

It looks like it depends on the strings being formatted by pretty_bytes, so its not always reproducible. I 'fixed' it temporarily on my fork by not calling pretty_bytes in pull_status_printer.