From e39182a64b65bb5a9c4169f5147ac3505e9025dc Mon Sep 17 00:00:00 2001 From: Jonas Rembser Date: Sun, 22 Jun 2025 09:46:14 +0200 Subject: [PATCH] [CI] Disable PyMVA so we can support the newest TensorFlow versions Right now we don't support the newest TensorFlow releases after the 2.15 series, initially released in November 2023 [1]. Support for TensorFlow>=2.16 is worked on [2], but it's difficult to make progress if we don't have TensorFlow>=2.16 in our CI images. And we veto it from our CI image via the `requirements.txt` mechanism. To continue, we need to temporarily disable PyMVA in the CI, such that we can include the newest TensorFlow version in our images, and then re-enable it in the PR that fixes support for the newest TensorFlow. This is what is done in this commit. Supporting the newest TensorFlow became a bit more important now that we also have another feature besides PyMVA that uses TensorFlow: the RBatchGenerator. It would not good to hold off testing the actively-developed RBatchGenerator on newer TensorFlow versions, just because PyMVA prevents us from installing these on our CI. [1] https://github.com/tensorflow/tensorflow/releases [2] https://github.com/root-project/root/pull/15790 --- .github/workflows/root-ci-config/buildconfig/global.txt | 2 +- .../workflows/root-ci-config/buildconfig/ubuntu2404-cuda.txt | 2 +- requirements.txt | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/root-ci-config/buildconfig/global.txt b/.github/workflows/root-ci-config/buildconfig/global.txt index 7f52981cff8e6..7e55022a04fa3 100644 --- a/.github/workflows/root-ci-config/buildconfig/global.txt +++ b/.github/workflows/root-ci-config/buildconfig/global.txt @@ -91,7 +91,7 @@ testing=ON tmva-cpu=ON tmva-gpu=OFF tmva-cudnn=OFF -tmva-pymva=ON +tmva-pymva=OFF tmva-rmva=OFF tmva-sofie=OFF tmva=ON diff --git a/.github/workflows/root-ci-config/buildconfig/ubuntu2404-cuda.txt b/.github/workflows/root-ci-config/buildconfig/ubuntu2404-cuda.txt index b7b693c1dbcfd..d2d9c7eaac5c4 100644 --- a/.github/workflows/root-ci-config/buildconfig/ubuntu2404-cuda.txt +++ b/.github/workflows/root-ci-config/buildconfig/ubuntu2404-cuda.txt @@ -6,7 +6,7 @@ tmva=ON tmva-cpu=ON tmva-gpu=ON tmva-cudnn=ON -tmva-pymva=ON +tmva-pymva=OFF fortran=OFF gdml=OFF spectrum=OFF diff --git a/requirements.txt b/requirements.txt index e3a915951105d..bb4e9155d1251 100644 --- a/requirements.txt +++ b/requirements.txt @@ -11,7 +11,7 @@ onnx # TMVA: PyMVA interfaces scikit-learn -tensorflow<2.16 ; python_version < "3.12" +tensorflow ; python_version < "3.13" # TensorFlow doesn't support Python 3.13 yet torch xgboost