Question about deprecated I/Fs

[roncapat]

Hi again,

may I ask the rationale for deprecating this I/F?

void encodeImage(const cv::Mat & img, const Header & header, const rclcpp::Time & t0);

this would be indeed very helpful for example if the user already has a cv::Mat obtained via intra-process comms through Type Adaptation, for example.

I'm concerned about leveraging a deprecated API and the future need to fork this very good package just because we're loosing such I/F.

[berndpfrommer]

I didn't realize that anybody else (other than ffmpeg_image_transport and foxglove_compressed_video transport) was actually using this package. And since those two no longer use the API I figured I'd deprecate it so future development will not use it.
I have no strong feelings about it and will happily roll back the deprecation if you want me to.

[roncapat]

Yes please :) As long as it's not too much of a burden for you to keep maintaining that I/F.

[berndpfrommer]

closed with PR #9