From 5bf6790e63fb788fb96b7a2cebafadeb07967e02 Mon Sep 17 00:00:00 2001 From: yadnyeshwar Date: Wed, 11 Mar 2026 17:16:50 +0000 Subject: [PATCH 1/3] Improve error message when parameter value is missing Signed-off-by: yadnyeshwar --- rclcpp/src/rclcpp/parameter_map.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rclcpp/src/rclcpp/parameter_map.cpp b/rclcpp/src/rclcpp/parameter_map.cpp index bf702c8aa6..49a594bd5d 100644 --- a/rclcpp/src/rclcpp/parameter_map.cpp +++ b/rclcpp/src/rclcpp/parameter_map.cpp @@ -152,7 +152,7 @@ rclcpp::parameter_value_from(const rcl_variant_t * const c_param_value) return ParameterValue(strings); } - throw InvalidParameterValueException("No parameter value set"); + throw InvalidParameterValueException("Invalid parameter value: rcl parameter strucure contains no value"); } ParameterMap From ffd5261f1ffcfc85c90efb8051bac7d4236c0add Mon Sep 17 00:00:00 2001 From: yadnyeshwar Date: Thu, 12 Mar 2026 16:38:56 +0000 Subject: [PATCH 2/3] Fix formatting for parameter value exception message Signed-off-by: yadnyeshwar --- rclcpp/src/rclcpp/parameter_map.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/rclcpp/src/rclcpp/parameter_map.cpp b/rclcpp/src/rclcpp/parameter_map.cpp index 49a594bd5d..869e0185c8 100644 --- a/rclcpp/src/rclcpp/parameter_map.cpp +++ b/rclcpp/src/rclcpp/parameter_map.cpp @@ -152,7 +152,8 @@ rclcpp::parameter_value_from(const rcl_variant_t * const c_param_value) return ParameterValue(strings); } - throw InvalidParameterValueException("Invalid parameter value: rcl parameter strucure contains no value"); + throw InvalidParameterValueException( + "Invalid parameter value: rcl parameter strucure contains no value"); } ParameterMap From 74d642d59e12466d1f41d8e4ad4baa34568449b5 Mon Sep 17 00:00:00 2001 From: yadnyeshwar Date: Thu, 12 Mar 2026 17:22:38 +0000 Subject: [PATCH 3/3] Fix cpplint line length for parameter exception message Signed-off-by: yadnyeshwar --- rclcpp/src/rclcpp/parameter_map.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/rclcpp/src/rclcpp/parameter_map.cpp b/rclcpp/src/rclcpp/parameter_map.cpp index 869e0185c8..d07c9c5426 100644 --- a/rclcpp/src/rclcpp/parameter_map.cpp +++ b/rclcpp/src/rclcpp/parameter_map.cpp @@ -153,7 +153,8 @@ rclcpp::parameter_value_from(const rcl_variant_t * const c_param_value) } throw InvalidParameterValueException( - "Invalid parameter value: rcl parameter strucure contains no value"); + "Invalid parameter value: rcl parameter structure" + " contains no value"); } ParameterMap