Skip to content

Commit 43d46da

Browse files
authored
Exit full-screen mode when a full-screen card is removed (#1005)
* fix(card): Exit full-screen mode when a full-screen card is removed * chore: yarn build * refactor(card): Just observe `document.body` for removals The card might be inside more dynamic UI, so we can't just observe from the parent node. * fix: find nested matching elements * chore: yarn build * Resave distributed files (GitHub Action) * Resave distributed files (GitHub Action) * Resave data (GitHub Action) * refactor: Use a Set instead of an array for `found` removed items * chore: yarn build * chore: try/catch `ShinyRemovedObserver` callback
1 parent 7fe3a97 commit 43d46da

File tree

7 files changed

+274
-9
lines changed

7 files changed

+274
-9
lines changed

NEWS.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,8 @@
4646

4747
* `page_navbar()` and `navset_bar()` now validate and transform `padding` and `gap` arguments into appropriate CSS values. (#991)
4848

49+
* Fixed an issue that could happen with a `card()` or `value_box()` that is rendered entirely via `renderUI()` when it is replaced by an updated card but the user had expanded the original card into full screen mode. Now the full screen state is reset for the new card or value box. If you want to update a card without potentially exiting the full-screen mode, update specific parts of the card using `uiOutput()` or `textOutput()`. (#1005)
50+
4951
# bslib 0.6.1
5052

5153
## Bug fixes

inst/components/dist/components.js

Lines changed: 130 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

inst/components/dist/components.js.map

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)