Skip to content

Commit 6444417

Browse files
committed
Add note explaining why rvalue_stack is not WB_PROTECTED
1 parent ad6b9cf commit 6444417

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

ext/json/ext/parser/parser.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -294,6 +294,8 @@ static const rb_data_type_t JSON_Parser_rvalue_stack_type = {
294294
.dsize = rvalue_stack_memsize,
295295
.dcompact = rvalue_stack_compact,
296296
},
297+
// We deliberately don't declare rvalue_stack as RUBY_TYPED_WB_PROTECTED
298+
// because it churns a lot of values so trigering write barriers every time is very costly.
297299
.flags = RUBY_TYPED_FREE_IMMEDIATELY | RUBY_TYPED_EMBEDDABLE,
298300
};
299301

0 commit comments

Comments
 (0)