Include operator overload occurrences in SCIP index #21187
+31
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
nicolas-guichard
commented
Dec 1, 2025
Comment on lines
-228
to
-233
| let tokens = tokens.filter(|token| { | ||
| matches!( | ||
| token.kind(), | ||
| IDENT | INT_NUMBER | LIFETIME_IDENT | T![self] | T![super] | T![crate] | T![Self] | ||
| ) | ||
| }); |
Contributor
Author
There was a problem hiding this comment.
Note: I removed the SyntaxKind-based filtering here because I didn't want to explicitly list all overloadable operators and get_definitions already filters out tokens that don't map to a definition, but I can add it back (with a proper SyntaxKind::is_overloadable_operator) if that's an issue.
rustbot
removed
the
S-waiting-on-review
Operators were explicitly filtered out, both when filtering tokens to search definitions for and when searching for actual definitions.
nicolas-guichard
force-pushed
the
push-orysqtulnxww
branch
from
d1c344b to
96340cb
Compare
rustbot
added
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Operators were explicitly filtered out, both when filtering tokens to search definitions for and when searching for actual definitions.
Fixes #21127