Fix fmt and dogfood lints for never_loop iterator reduction

Author: cuongleqq

clippy_lints/src/loops/mod.rs

@@ -893,13 +893,7 @@ impl<'tcx> LateLintPass<'tcx> for Loops {
         if let ExprKind::MethodCall(path, recv, args, _) = expr.kind
             && matches!(
                 path.ident.name,
-                sym::for_each
-                    | sym::try_for_each
-                    | sym::fold
-                    | sym::try_fold
-                    | sym::reduce
-                    | sym::all
-                    | sym::any
+                sym::for_each | sym::try_for_each | sym::fold | sym::try_fold | sym::reduce | sym::all | sym::any
             )
             && ty::get_iterator_item_ty(cx, cx.typeck_results().expr_ty(recv)).is_some()
         {

clippy_lints/src/loops/never_loop.rs

@@ -88,7 +88,7 @@ pub(super) fn check_iterator_reduction<'tcx>(
     };
 
     let closure_arg = match method_name {
-        sym::for_each | sym::try_for_each | sym::reduce | sym::all | sym::any => args.get(0),
+        sym::for_each | sym::try_for_each | sym::reduce | sym::all | sym::any => args.first(),
         sym::fold | sym::try_fold => args.get(1),
         _ => None,
     };
@@ -118,7 +118,6 @@ pub(super) fn check_iterator_reduction<'tcx>(
                 diag.span_suggestion_verbose(expr.span, "consider this pattern", sugg, app);
             },
         );
-        return;
     }
 }
 

clippy_utils/src/sym.rs

@@ -66,7 +66,6 @@ generate! {
     Regex,
     RegexBuilder,
     RegexSet,
-    reduce,
     Start,
     Symbol,
     SyntaxContext,
@@ -276,6 +275,7 @@ generate! {
     read_to_string,
     read_unaligned,
     read_volatile,
+    reduce,
     redundant_imports,
     redundant_pub_crate,
     regex,