-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
Description
According to the lang team, no rfc is required while the feature is kept unstable. See #t-lang > RFC for `#[diagnostic:on_move(message)]`(PR #150935)
The feature gate for the issue is #![feature(diagnostic_on_move)]
This tracking issue is opened once the corresponding PR is merged, sorry for that.
About tracking issues
Tracking issues are used to record the overall progress of implementation.
They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions.
A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature.
Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.
Discussion comments will get marked as off-topic or deleted.
Repeated discussions on the tracking issue may lead to the tracking issue getting locked.
Steps
- Implement the feature
- Point to this tracking issue in
compiler/rustc_feature/src/unstable.rs - Adjust documentation (see instructions on rustc-dev-guide)
- Style updates for any new syntax (nightly-style-procedure)
- Style team decision on new formatting
- Formatting for new syntax has been added to the Style Guide
- (non-blocking) Formatting has been implemented in
rustfmt
- Stabilization PR (see instructions on rustc-dev-guide)
Unresolved Questions
I think it would be interesting to start using this diagnostic attribute in rustc, perhaps on some internal types in rustc, or as part of the standard library, this would be a good testing area.