rust-analyzer subtree update
#149766
Merged
rust-analyzer subtree update
#149766
+1,462
−1,397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that we'll correctly treat it as an attribute. I don't like that we have to register every builtin macro even if we don't need it, but that's what we got.
fix: Register `define_opaque` builtin attribute macro
In the inferred type hints, expand the line too long. add config to disable it.
Example
---
```json
{"rust-analyzer.inlayHints.typeHints.hideInferredTypes": true}
```
```rust
use std::collections::HashMap;
fn foo(iter: Vec<Result<HashMap<String, String>, std::io::Error>>) {
let output = iter.into_iter().collect::<Result<Vec<_>, _>>().unwrap();
}
```
**Before this PR**
```rust
let output: Vec<HashMap<String, String>> = iter.into_iter().collect::<Result<Vec<_ = HashMap<String, String>>, _ = Error>>().unwrap();
```
**After this PR**
```rust
let output: Vec<HashMap<String, String>> = iter.into_iter().collect::<Result<Vec<_>, _>>().unwrap();
```
…match fix: Skip cfg attributes in macro input attribute stripping
Add config hide placeholders type hints
This avoids code duplication.
internal: Handle lint attributes via hir-expand attr handling
Since we don't implement it currently for perf reasons, but here we only need a struct's tail field, it will be wrong.
We no longer work properly with older versions.
…ted-version internal: Update supported Rust version to 1.90.0
fix: Don't implement sizedness check via `all_field_tys()`
optimize some stuff Optimize `pub(crate)` visibility resolution Optimize private visibility resolution
internal: Make `ModuleId` a tracked struct
Example
---
```rust
use core::future::Future;
trait DesugaredAsyncTrait {
fn foo(&self) -> impl Future<Output = ()> + Send;
}
impl DesugaredAsyncTrait for () {
$0
}
```
**Before this PR**
```rust
use core::future::Future;
trait DesugaredAsyncTrait {
fn foo(&self) -> impl Future<Output = ()> + Send;
}
impl DesugaredAsyncTrait for () {
async fn foo(&self) -> () {
$0
}
}
```
**After this PR**
```rust
use core::future::Future;
trait DesugaredAsyncTrait {
fn foo(&self) -> impl Future<Output = ()> + Send;
}
impl DesugaredAsyncTrait for () {
async fn foo(&self) {
$0
}
}
```
fix: Disable postcard use temporarily
…-ret-ty No complete unit RetType in resugar async assoc item
Collaborator
|
rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead. cc @rust-lang/rust-analyzer |
rustbot
added
S-waiting-on-review
Member
Author
|
@bors r+ p=1 subtree sync |
Collaborator
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 5bc3450 (parent) -> 37aa213 (this PR) Test differencesShow 4 test diffs4 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 37aa2135b5d0936bd13aa699d941aaa94fbaa645 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
Finished benchmarking commit (37aa213): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary -1.6%, secondary -1.8%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary -0.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 473.701s -> 470.452s (-0.69%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subtree update of
rust-analyzerto rust-lang/rust-analyzer@5e3e9c4.Created using https://github.com/rust-lang/josh-sync.
r? @ghost