diff --git a/src/librustdoc/passes/check_doc_test_visibility.rs b/src/librustdoc/passes/check_doc_test_visibility.rs index 40dfdb890d66f..a1578ab40209a 100644 --- a/src/librustdoc/passes/check_doc_test_visibility.rs +++ b/src/librustdoc/passes/check_doc_test_visibility.rs @@ -79,8 +79,7 @@ pub(crate) fn should_have_doc_example(cx: &DocContext<'_>, item: &clean::Item) - | clean::ProvidedAssocConstItem(..) | clean::ImplAssocConstItem(..) | clean::RequiredAssocTypeItem(..) - // check for trait impl - | clean::ImplItem(box clean::Impl { trait_: Some(_), .. }) + | clean::ImplItem(_) ) { return false; diff --git a/tests/rustdoc-ui/lints/lint-missing-doc-code-example.rs b/tests/rustdoc-ui/lints/lint-missing-doc-code-example.rs index 8e5c31d50edc7..731d19bffec52 100644 --- a/tests/rustdoc-ui/lints/lint-missing-doc-code-example.rs +++ b/tests/rustdoc-ui/lints/lint-missing-doc-code-example.rs @@ -78,7 +78,11 @@ impl Clone for Struct { } } - +impl Struct { // No doc or code example and it's fine! + pub fn bar() {} + //~^ ERROR missing code example in this documentation + //~| ERROR missing documentation for an associated function +} /// doc /// diff --git a/tests/rustdoc-ui/lints/lint-missing-doc-code-example.stderr b/tests/rustdoc-ui/lints/lint-missing-doc-code-example.stderr index 22533b9816a74..6382c5926e8fc 100644 --- a/tests/rustdoc-ui/lints/lint-missing-doc-code-example.stderr +++ b/tests/rustdoc-ui/lints/lint-missing-doc-code-example.stderr @@ -1,3 +1,15 @@ +error: missing documentation for an associated function + --> $DIR/lint-missing-doc-code-example.rs:82:5 + | +LL | pub fn bar() {} + | ^^^^^^^^^^^^ + | +note: the lint level is defined here + --> $DIR/lint-missing-doc-code-example.rs:2:9 + | +LL | #![deny(missing_docs)] + | ^^^^^^^^^^^^ + error: missing code example in this documentation --> $DIR/lint-missing-doc-code-example.rs:38:3 | @@ -28,5 +40,11 @@ error: missing code example in this documentation LL | /// Doc | ^^^^^^^ -error: aborting due to 4 previous errors +error: missing code example in this documentation + --> $DIR/lint-missing-doc-code-example.rs:82:5 + | +LL | pub fn bar() {} + | ^^^^^^^^^^^^^^^ + +error: aborting due to 6 previous errors