Skip to content

Commit 79fae3c

Browse files
committed
ci: update dist workflow
1 parent f9e21b7 commit 79fae3c

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

.github/workflows/release.yml

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@
1111
# * uploads those artifacts to temporary workflow zip
1212
# * on success, uploads the artifacts to a GitHub Release
1313
#
14-
# Note that the GitHub Release will be created with a generated
15-
# title/body based on your changelogs.
14+
# Note that a GitHub Release with this tag is assumed to exist as a draft
15+
# with the appropriate title/body, and will be undrafted for you.
1616

1717
name: Release
1818
permissions:
@@ -270,14 +270,12 @@ jobs:
270270
- name: Create GitHub Release
271271
env:
272272
PRERELEASE_FLAG: "${{ fromJson(steps.host.outputs.manifest).announcement_is_prerelease && '--prerelease' || '' }}"
273-
ANNOUNCEMENT_TITLE: "${{ fromJson(steps.host.outputs.manifest).announcement_title }}"
274-
ANNOUNCEMENT_BODY: "${{ fromJson(steps.host.outputs.manifest).announcement_github_body }}"
275273
RELEASE_COMMIT: "${{ github.sha }}"
276274
run: |
277-
# Write and read notes from a file to avoid quoting breaking things
278-
echo "$ANNOUNCEMENT_BODY" > $RUNNER_TEMP/notes.txt
275+
# If we're editing a release in place, we need to upload things ahead of time
276+
gh release upload "${{ needs.plan.outputs.tag }}" artifacts/*
279277
280-
gh release create "${{ needs.plan.outputs.tag }}" --target "$RELEASE_COMMIT" $PRERELEASE_FLAG --title "$ANNOUNCEMENT_TITLE" --notes-file "$RUNNER_TEMP/notes.txt" artifacts/*
278+
gh release edit "${{ needs.plan.outputs.tag }}" --target "$RELEASE_COMMIT" $PRERELEASE_FLAG --draft=false
281279
282280
publish-homebrew-formula:
283281
needs:

dist-workspace.toml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,3 +19,5 @@ install-path = "CARGO_HOME"
1919
publish-jobs = ["homebrew"]
2020
# Whether to install an updater program
2121
install-updater = false
22+
# Whether dist should create a Github Release or use an existing draft
23+
create-release = false

0 commit comments

Comments
 (0)