fix: add newer-version-available to the recommended list (#162)

Author: scarrawaySF

package.json

@@ -28,7 +28,7 @@
         "semver": "^7.6.2"
     },
     "devDependencies": {
-        "@lwc/eslint-plugin-lwc": "^3.0.0",
+        "@lwc/eslint-plugin-lwc": "^3.3.0",
         "@salesforce/eslint-plugin-lightning": "^2.0.0",
         "eslint": "^9.17.0",
         "eslint-plugin-import": "^2.31.0",

recommended.js

@@ -124,6 +124,7 @@ module.exports = [
                 },
             ],
             '@lwc/lwc/valid-graphql-wire-adapter-callback-parameters': 'error',
+            '@lwc/lwc/newer-version-available': 'error',
 
             // Lightning
             '@salesforce/lightning/valid-apex-method-invocation': 'error',

test/recommended.js

@@ -158,7 +158,7 @@ describe('recommended config', () => {
 
         const results = await cli.lintText(`
             import { wire } from 'lwc';
-            import { gql, graphql } from 'lightning/uiGraphQLApi';
+            import { gql, graphql } from 'lightning/graphql';
         
             class Test {
                 @wire(graphql, {})
@@ -172,6 +172,23 @@ describe('recommended config', () => {
             '@lwc/lwc/valid-graphql-wire-adapter-callback-parameters',
         );
     });
+
+    it('should suggest upgrading to new versions of libraries', async () => {
+        const cli = getCliEngineWithRecommendedRules();
+
+        const results = await cli.lintText(`
+            import { wire } from 'lwc';
+            import { gql, graphql } from 'lightning/uiGraphQLApi';
+        
+            class Test {
+                @wire(graphql, {})
+                wiredMethod({errors, data}) {}
+        }`);
+
+        const { messages } = results[0];
+        assert.strictEqual(messages.length, 5);
+        assert.strictEqual(messages[0].ruleId, '@lwc/lwc/newer-version-available');
+    });
 });
 
 describe('typescript recommended config', () => {
@@ -310,7 +327,7 @@ describe('typescript recommended config', () => {
 
         const results = await cli.lintText(`
             import { wire } from 'lwc';
-            import { gql, graphql } from 'lightning/uiGraphQLApi';
+            import { gql, graphql } from 'lightning/graphql';
         
             class Test {
                 @wire(graphql, {})

yarn.lock

@@ -297,10 +297,10 @@
     "@jridgewell/resolve-uri" "^3.1.0"
     "@jridgewell/sourcemap-codec" "^1.4.14"
 
-"@lwc/eslint-plugin-lwc@^3.0.0":
-  version "3.0.0"
-  resolved "https://registry.yarnpkg.com/@lwc/eslint-plugin-lwc/-/eslint-plugin-lwc-3.0.0.tgz#df5168cb951540ad41750cccfec06a047a2062bd"
-  integrity sha512-98Z9Jo/w/g5rvaCwW53MooEozle+Cz8ixSpdGS3ndcU3pxWPMuexzrkbEtWny3YKYR6tKw9QXlaDL8hexE4zMA==
+"@lwc/eslint-plugin-lwc@^3.3.0":
+  version "3.3.0"
+  resolved "https://registry.yarnpkg.com/@lwc/eslint-plugin-lwc/-/eslint-plugin-lwc-3.3.0.tgz#6b1b955579797e0989304da9f875aa9f6118b54a"
+  integrity sha512-qTcRGGTdBAfuPlJTL2sTk65skQHqnthz8TRx/1IasFZb+aljSn+CamnaPyzq8s2xAzQsS+NZJQoWlrZjyzzCzw==
   dependencies:
     fast-xml-parser "^4.5.1"
     globals "~15.14.0"