Merge branch 'development' release 0.5.3

Author: samrocketman

CHANGELOG.md

@@ -1,3 +1,11 @@
+---
+## gitlab-mirrors v0.5.3
+
+* Bugfix `git-mirrors.sh` while loop executing in a subshell and the value of
+  `STATUS` being lost.  See [PR #92][#92].
+
+[#92]: https://github.com/samrocketman/gitlab-mirrors/pull/92
+
 ---
 ## gitlab-mirrors v0.5.2
 

README.md

@@ -1,16 +1,13 @@
 # gitlab-mirrors
 
 The [gitlab-mirrors](https://github.com/samrocketman/gitlab-mirrors) project is
-designed to fill in a feature which is currently
-[missing from GitLab][mirror-missing]: the ability to mirror remote
-repositories.  gitlab-mirrors creates read only copies of remote repositories in
-gitlab.  It provides a CLI management interface for managing the mirrored
-repositories (e.g. add, delete, update) so that an admin may regularly update
-all mirrors using `crontab`.  It operates by interacting with the
-[GitLab API][gitlab-api] using [python-gitlab3][python-gitlab3].  Also, check
-out this cool [puppet module][puppet] for installing and configuring
-gitlab-mirrors.
-
+designed to fill in a feature which is currently [missing from
+GitLab][mirror-missing]: the ability to mirror remote repositories.
+gitlab-mirrors creates read only copies of remote repositories in gitlab.  It
+provides a CLI management interface for managing the mirrored repositories (e.g.
+add, delete, update) so that an admin may regularly update all mirrors using
+`crontab`.  It operates by interacting with the [GitLab API][gitlab-api] using
+[python-gitlab3][python-gitlab3].
 
 ## Features
 
@@ -46,13 +43,18 @@ gitlab-mirrors.
 
 *Note: if you are upgrading then see `docs/upgrade` for notes on upgrading.*
 
+---
+# Other helpful implementations
+
+* [Puppet module][gm-puppet] for installing and configuring gitlab-mirrors.
+* [Docker container][gm-docker] for mirroring repositories.
 
 ---
 # Get help
 
-There are a couple ways you can try to get help.  You can
-[file an issue][issues].  You can also join the `#gitlab` IRC channel at
-freenode.net and direct your questions to user `sag47`.
+There are a couple ways you can try to get help.  You can [file an
+issue][issues].  You can also join the `#gitlab` IRC channel at freenode.net and
+direct your questions to user `sag47`.
 
 ## IRC Etiquette
 
@@ -81,7 +83,8 @@ Created by Sam Gleske under [MIT License](LICENSE).
 * Fixed project transfer bug #78 [Corey Osman](https://github.com/logicminds)
 
 [gitlab-api]: http://api.gitlab.org/
+[gm-docker]: https://github.com/Klowner/docker-gitlab-mirrors
+[gm-puppet]: https://github.com/logicminds/gitlab_mirrors
 [issues]: https://github.com/samrocketman/gitlab-mirrors/issues
 [mirror-missing]: http://feedback.gitlab.com/forums/176466-general/suggestions/4286666-mirror-git-svn-into-repo-
-[puppet]: https://github.com/logicminds/gitlab_mirrors
 [python-gitlab3]: https://github.com/alexvh/python-gitlab3

git-mirrors.sh

@@ -17,10 +17,12 @@ cd "${git_mirrors_dir}"
 
 STATUS=0
 
-ls -1 "${repo_dir}/${gitlab_namespace}" | while read mirror;do
+while read mirror
+do
   if ! ./update_mirror.sh "${mirror}" >> ${git_mirrors_dir}/cron.log 2>&1 ;then
     red_echo "Error: ./update_mirror.sh ${mirror} (more information in ${git_mirrors_dir}/cron.log)" 1>&2
     STATUS=1
   fi
-done
+done <<< "$(ls -1 "${repo_dir}/${gitlab_namespace}")"
+
 exit ${STATUS}

lib/VERSION

@@ -1 +1 @@
-VERSION="v0.5.2"
+VERSION="v0.5.3"