github-releases: no need to explicitly check 302

talal · talal · commit 4ce3d773c389 · 2022-05-19T17:17:17.000+02:00
http.Client will handle that for us.
diff --git a/pkg/objects/github.go b/pkg/objects/github.go
@@ -214,7 +214,6 @@ func (s *GithubReleaseSource) GetFile(path string, requestHeaders schwift.Object
 	}
 
 	if resp.StatusCode != http.StatusOK &&
-		resp.StatusCode != http.StatusFound && // as per GitHub docs, clients should also handle 302 response
 		resp.StatusCode != http.StatusNotModified {
 		return nil, FileState{}, fmt.Errorf(
 			"skipping %s: GET returned unexpected status code: expected one of [200, 302, 304] but got %d",

Original file line number	Diff line number	Diff line change
`@@ -214,7 +214,6 @@ func (s *GithubReleaseSource) GetFile(path string, requestHeaders schwift.Object`
`214`	`214`	`}`
`215`	`215`
`216`	`216`	`if resp.StatusCode != http.StatusOK &&`
`217`		`- resp.StatusCode != http.StatusFound && // as per GitHub docs, clients should also handle 302 response`
`218`	`217`	`resp.StatusCode != http.StatusNotModified {`
`219`	`218`	`return nil, FileState{}, fmt.Errorf(`
`220`	`219`	`"skipping %s: GET returned unexpected status code: expected one of [200, 302, 304] but got %d",`