-
Notifications
You must be signed in to change notification settings - Fork 156
feat(redis): add cluster connect command #5211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5211 +/- ##
==========================================
- Coverage 58.36% 58.30% -0.06%
==========================================
Files 311 311
Lines 68512 68637 +125
==========================================
+ Hits 39990 40022 +32
- Misses 27037 27129 +92
- Partials 1485 1486 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1b1777f to
68afb9d
Compare
| scw redis cluster connect | ||
|
|
||
| Connect to a Redis cluster via private network | ||
| scw redis cluster connect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it normal that the private network is not mentioned here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed! I've updated the examples to use Raw instead of ArgsJSON so they explicitly show the private-network=true flag.
| Short: "Command line tool to use, default to redis-cli", | ||
| }, | ||
| core.ZoneArgSpec( | ||
| scw.ZoneFrPar1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could it be defined with a zones coming from the SDK instead of explicitly?
| cliRedis, | ||
| "-h", hostStr, | ||
| "-p", strconv.FormatUint(uint64(port), 10), | ||
| "-a", password, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to have an argument passed through the command line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! The cli-args parameter allows passing additional arguments to redis-cli. Example: scw redis cluster connect <cluster-id> cli-args.0=--raw
close #2961
Community Note
Relates OR Closes #0000
Release note for CHANGELOG: