Skip to content

Conversation

@jremy42
Copy link
Contributor

@jremy42 jremy42 commented Dec 5, 2025

close #2961

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


@jremy42 jremy42 requested a review from a team as a code owner December 5, 2025 09:24
@github-actions github-actions bot added the redis Managed Redis issues, bugs and feature requests label Dec 5, 2025
@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2025

Codecov Report

❌ Patch coverage is 26.19048% with 93 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.30%. Comparing base (660e8b8) to head (b385d39).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
internal/namespaces/redis/v1/custom_cluster.go 25.60% 92 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5211      +/-   ##
==========================================
- Coverage   58.36%   58.30%   -0.06%     
==========================================
  Files         311      311              
  Lines       68512    68637     +125     
==========================================
+ Hits        39990    40022      +32     
- Misses      27037    27129      +92     
- Partials     1485     1486       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@remyleone remyleone marked this pull request as draft December 5, 2025 09:34
@jremy42 jremy42 force-pushed the feat/redis-connect branch from 1b1777f to 68afb9d Compare December 8, 2025 10:07
@jremy42 jremy42 marked this pull request as ready for review December 8, 2025 10:40
@jremy42 jremy42 requested a review from remyleone as a code owner December 8, 2025 10:40
scw redis cluster connect

Connect to a Redis cluster via private network
scw redis cluster connect
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it normal that the private network is not mentioned here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed! I've updated the examples to use Raw instead of ArgsJSON so they explicitly show the private-network=true flag.

Short: "Command line tool to use, default to redis-cli",
},
core.ZoneArgSpec(
scw.ZoneFrPar1,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could it be defined with a zones coming from the SDK instead of explicitly?

cliRedis,
"-h", hostStr,
"-p", strconv.FormatUint(uint64(port), 10),
"-a", password,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to have an argument passed through the command line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! The cli-args parameter allows passing additional arguments to redis-cli. Example: scw redis cluster connect <cluster-id> cli-args.0=--raw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

redis Managed Redis issues, bugs and feature requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a connect function to redis

4 participants