Use return values in OverloadResolution, drop Error Prone opt-out

Author: jupblb

tests/minimized/BUILD

@@ -11,8 +11,5 @@ java_library(
 	],
 	javacopts = [
           "'-Xplugin:scip -build-tool:bazel'",
-          # These are deliberately minimal SCIP indexer inputs (e.g. ignored
-          # return values), not production code, so skip Error Prone linting.
-          "-XepDisableAllChecks",
 	],
 )

tests/minimized/src/main/java/minimized/OverloadResolution.java

@@ -6,10 +6,10 @@
  * symbols (lastIndexOf(), (+1), (+2), (+3)).
  */
 public class OverloadResolution {
-  public static void app() {
-    "".lastIndexOf('a');
-    "".lastIndexOf('b', 0);
-    "".lastIndexOf("c");
-    "".lastIndexOf("d", 0);
+  public static int app() {
+    return "".lastIndexOf('a')
+        + "".lastIndexOf('b', 0)
+        + "".lastIndexOf("c")
+        + "".lastIndexOf("d", 0);
   }
 }

tests/snapshots/src/main/generated/tests/minimized/src/main/java/minimized/OverloadResolution.java

@@ -22,20 +22,20 @@ public class OverloadResolution {
 //                                signature_documentation
 //                                > public OverloadResolution()
 //  ⌄ enclosing_range_start scip-java maven . . minimized/OverloadResolution#app().
-    public static void app() {
-//                     ^^^ definition scip-java maven . . minimized/OverloadResolution#app().
-//                         kind StaticMethod
-//                         display_name app
-//                         signature_documentation
-//                         > public static void app()
-      "".lastIndexOf('a');
-//       ^^^^^^^^^^^ reference scip-java maven jdk 11 java/lang/String#lastIndexOf().
-      "".lastIndexOf('b', 0);
-//       ^^^^^^^^^^^ reference scip-java maven jdk 11 java/lang/String#lastIndexOf(+1).
-      "".lastIndexOf("c");
-//       ^^^^^^^^^^^ reference scip-java maven jdk 11 java/lang/String#lastIndexOf(+2).
-      "".lastIndexOf("d", 0);
-//       ^^^^^^^^^^^ reference scip-java maven jdk 11 java/lang/String#lastIndexOf(+3).
+    public static int app() {
+//                    ^^^ definition scip-java maven . . minimized/OverloadResolution#app().
+//                        kind StaticMethod
+//                        display_name app
+//                        signature_documentation
+//                        > public static int app()
+      return "".lastIndexOf('a')
+//              ^^^^^^^^^^^ reference scip-java maven jdk 11 java/lang/String#lastIndexOf().
+          + "".lastIndexOf('b', 0)
+//             ^^^^^^^^^^^ reference scip-java maven jdk 11 java/lang/String#lastIndexOf(+1).
+          + "".lastIndexOf("c")
+//             ^^^^^^^^^^^ reference scip-java maven jdk 11 java/lang/String#lastIndexOf(+2).
+          + "".lastIndexOf("d", 0);
+//             ^^^^^^^^^^^ reference scip-java maven jdk 11 java/lang/String#lastIndexOf(+3).
     }
 //  ⌃ enclosing_range_end scip-java maven . . minimized/OverloadResolution#app().
   }