Move javac test harness into scip-javac, drop tests/unit project

Author: jupblb

build.sbt

@@ -153,7 +153,15 @@ lazy val javacPlugin = project
             "org.relaxng.**" -> "com.sourcegraph.shaded.relaxng.@1"
           )
           .inAll
-      )
+      ),
+    // JUnit 5 for the colocated in-process javac tests (test scope only, so it
+    // stays out of the published scip-javac POM).
+    libraryDependencies += "com.github.sbt.junit" % "jupiter-interface" %
+      JupiterKeys.jupiterVersion.value % Test,
+    Test / fork := true,
+    // The tests drive javac in-process via ScipPlugin; on JDK 17+ this requires
+    // the JDK-internal javac packages to be opened.
+    Test / javaOptions ++= javacModuleOptions.map(_.stripPrefix("-J"))
   )
   .dependsOn(scipShared)
 
@@ -551,11 +559,6 @@ def javacModuleOptions = List(
   "-J--add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED"
 )
 
-lazy val unit = project
-  .in(file("tests/unit"))
-  .settings(javaOnlySettings, javaJUnitTestSettings)
-  .dependsOn(javacPlugin)
-
 lazy val buildTools = project
   .in(file("tests/buildTools"))
   .enablePlugins(KotlinPlugin)

…t/src/main/java/tests/CompileResult.java …ourcegraph/scip_javac/CompileResult.javatests/unit/src/main/java/tests/CompileResult.java renamed to scip-javac/src/test/java/com/sourcegraph/scip_javac/CompileResult.java tests/unit/src/main/java/tests/CompileResult.java renamed to scip-javac/src/test/java/com/sourcegraph/scip_javac/CompileResult.java

@@ -1,4 +1,4 @@
-package tests;
+package com.sourcegraph.scip_javac;
 
 import java.util.Collections;
 import java.util.List;

…ava/tests/JavacClassesDirectoryTest.java …cip_javac/JavacClassesDirectoryTest.javatests/unit/src/test/java/tests/JavacClassesDirectoryTest.java renamed to scip-javac/src/test/java/com/sourcegraph/scip_javac/JavacClassesDirectoryTest.java tests/unit/src/test/java/tests/JavacClassesDirectoryTest.java renamed to scip-javac/src/test/java/com/sourcegraph/scip_javac/JavacClassesDirectoryTest.java

@@ -1,4 +1,4 @@
-package tests;
+package com.sourcegraph.scip_javac;
 
 import static org.junit.jupiter.api.Assertions.assertTrue;
 

…src/main/java/tests/SimpleClassFile.java …rcegraph/scip_javac/SimpleClassFile.javatests/unit/src/main/java/tests/SimpleClassFile.java renamed to scip-javac/src/test/java/com/sourcegraph/scip_javac/SimpleClassFile.java tests/unit/src/main/java/tests/SimpleClassFile.java renamed to scip-javac/src/test/java/com/sourcegraph/scip_javac/SimpleClassFile.java

@@ -1,4 +1,4 @@
-package tests;
+package com.sourcegraph.scip_javac;
 
 import java.io.ByteArrayOutputStream;
 import java.io.IOException;

…c/main/java/tests/SimpleFileManager.java …egraph/scip_javac/SimpleFileManager.javatests/unit/src/main/java/tests/SimpleFileManager.java renamed to scip-javac/src/test/java/com/sourcegraph/scip_javac/SimpleFileManager.java tests/unit/src/main/java/tests/SimpleFileManager.java renamed to scip-javac/src/test/java/com/sourcegraph/scip_javac/SimpleFileManager.java

@@ -1,6 +1,5 @@
-package tests;
+package com.sourcegraph.scip_javac;
 
-import com.sourcegraph.scip_javac.ScipPlugin;
 import java.net.URI;
 import java.nio.file.Path;
 import java.util.ArrayList;

…rc/main/java/tests/SimpleSourceFile.java …cegraph/scip_javac/SimpleSourceFile.javatests/unit/src/main/java/tests/SimpleSourceFile.java renamed to scip-javac/src/test/java/com/sourcegraph/scip_javac/SimpleSourceFile.java tests/unit/src/main/java/tests/SimpleSourceFile.java renamed to scip-javac/src/test/java/com/sourcegraph/scip_javac/SimpleSourceFile.java

@@ -1,4 +1,4 @@
-package tests;
+package com.sourcegraph.scip_javac;
 
 import java.nio.file.Path;
 import javax.tools.SimpleJavaFileObject;

…it/src/main/java/tests/TestCompiler.java …sourcegraph/scip_javac/TestCompiler.javatests/unit/src/main/java/tests/TestCompiler.java renamed to scip-javac/src/test/java/com/sourcegraph/scip_javac/TestCompiler.java tests/unit/src/main/java/tests/TestCompiler.java renamed to scip-javac/src/test/java/com/sourcegraph/scip_javac/TestCompiler.java

@@ -1,4 +1,4 @@
-package tests;
+package com.sourcegraph.scip_javac;
 
 import java.io.IOException;
 import java.io.StringWriter;

…nit/src/main/java/tests/VirtualFile.java …/sourcegraph/scip_javac/VirtualFile.javatests/unit/src/main/java/tests/VirtualFile.java renamed to scip-javac/src/test/java/com/sourcegraph/scip_javac/VirtualFile.java tests/unit/src/main/java/tests/VirtualFile.java renamed to scip-javac/src/test/java/com/sourcegraph/scip_javac/VirtualFile.java

@@ -1,4 +1,4 @@
-package tests;
+package com.sourcegraph.scip_javac;
 
 /**
  * Minimal in-memory source file (relative path + text), replacing the former use of scalameta's