compiler pass roundup

Author: scivision

.appveyor.yml

@@ -4,14 +4,14 @@ image:
 
 environment:
   MINGW_DIR: C:\mingw-w64\x86_64-7.2.0-posix-seh-rt_v5-rev1\mingw64\bin
-  CMAKE_GENERATOR: "MinGW Makefiles"
 
 clone_depth: 3
 
 build: off
 
 init:
 - cmd: set PATH=%MINGW_DIR%;%PATH%
+- cmd: set CMAKE_GENERATOR="MinGW Makefiles"
 - sh: sudo apt install -yq --no-install-recommends libscalapack-openmpi-dev libopenmpi-dev openmpi-bin
 
 install:

README.md

@@ -1,6 +1,4 @@
 [![Build Status](https://dev.azure.com/mhirsch0512/fortran2018-examples/_apis/build/status/scivision.fortran2018-examples?branchName=master)](https://dev.azure.com/mhirsch0512/fortran2018-examples/_build/latest?definitionId=8&branchName=master)
-[![image](https://travis-ci.org/scivision/fortran2018-examples.svg?branch=master)](https://travis-ci.org/scivision/fortran2018-examples)
-[![image](https://ci.appveyor.com/api/projects/status/kk2gcmlw1l3pjxy5?svg=true)](https://ci.appveyor.com/project/scivision/fortran2018-examples)
 
 
 # Fortran 2018 Examples

azure-pipelines.yml

@@ -3,7 +3,6 @@ jobs:
 - job: Ubuntu
   pool:
     vmImage: ubuntu-latest
-
   steps:
   - task: UsePythonVersion@0
     inputs:
@@ -12,25 +11,26 @@ jobs:
   - script: |
       sudo add-apt-repository -y ppa:ubuntu-toolchain-r/test
       sudo apt update -q
-      sudo apt install -yq --no-install-recommends gfortran-6
+      sudo apt install -yq --no-install-recommends gcc-6 gfortran-6 g++-6
       curl -Ls https://github.com/ninja-build/ninja/releases/download/v1.9.0/ninja-linux.zip -o ninja-linux.zip
       sudo unzip ninja-linux.zip -d /usr/local/bin/
       python -m pip install meson
     displayName: 'Install Prereqs'
   - script: meson setup build
     env:
       FC: gfortran-6
+      CC: gcc-6
+      CXX: g++-6
     displayName: 'Configure build'
   - script: meson test -C build
     displayName: 'build and test'
   - publish: build/meson-logs/testlog.txt
     condition: succeededOrFailed()
     artifact: LinuxMesonTestLog
 
-- job: MacOS
+- job: MacMeson
   pool:
     vmImage: macOS-latest
-
   steps:
   - task: UsePythonVersion@0
     inputs:
@@ -46,10 +46,9 @@ jobs:
     condition: succeededOrFailed()
     artifact: MacMesonTestLog
 
-- job: WindowsMinGW
+- job: WindowsMeson
   pool:
     vmImage: windows-latest
-
   steps:
   - task: UsePythonVersion@0
     inputs:
@@ -65,4 +64,20 @@ jobs:
     displayName: 'build and test'
   - publish: build/meson-logs/testlog.txt
     condition: succeededOrFailed()
-    artifact: WindowsMesonTestLog
+    artifact: WindowsMesonTestLog
+
+- job: WindowsCMake
+  pool:
+    vmImage: windows-latest
+  steps:
+  - script: cinst -y mingw cmake
+    displayName: 'Install Prereqs'
+  - script: cmake -B build
+    displayName: 'Configure build'
+    env:
+      CMAKE_GENERATOR: "MinGW Makefiles"
+  - script: cmake --build build --parallel
+    displayName: build
+  - script: ctest --parallel -V
+    displayName: run tests
+    workingDirectory: build

coarray/CMakeLists.txt

@@ -10,15 +10,16 @@ if(NOT Coarray_FOUND)
   return()
 endif()
 
+# "sync all" call is necessary to actually verify dynamically linked MPI stack works.
 include(CheckFortranSourceRuns)
 set(CMAKE_REQUIRED_FLAGS ${Coarray_COMPILE_OPTIONS})
 set(CMAKE_REQUIRED_LIBRARIES ${Coarray_LIBRARY})
-check_fortran_source_runs("real :: x[*]; end"
+check_fortran_source_runs("sync all; end"
   f08coarray SRC_EXT f90)
 if(NOT f08coarray)
   return()
 endif()
-check_fortran_source_runs("real :: x[*]; call co_sum(x); end"
+check_fortran_source_runs("real :: x[*]; call co_sum(x); sync all; end"
   f18coarray SRC_EXT f90)
 
 
@@ -27,7 +28,7 @@ target_compile_options(coarray_hello PRIVATE ${FFLAGS} ${Coarray_COMPILE_OPTIONS
 target_link_libraries(coarray_hello PRIVATE ${FLIBS} ${Coarray_LIBRARIES})
 add_test(NAME CoarrayHello
          COMMAND ${Coarray_EXECUTABLE} ${Coarray_NUMPROC_FLAG} ${Coarray_MAX_NUMPROCS} $<TARGET_FILE:coarray_hello>)
-
+set_tests_properties(CoarrayHello PROPERTIES TIMEOUT 20 RUN_SERIAL TRUE)
 
 if(f18coarray)
   add_executable(coarray_pi pi.f90)
@@ -39,4 +40,4 @@ target_compile_options(coarray_pi PRIVATE ${FFLAGS} ${Coarray_COMPILE_OPTIONS})
 target_link_libraries(coarray_pi PRIVATE ${FLIBS} ${Coarray_LIBRARIES})
 add_test(NAME CoarrayPi
          COMMAND ${Coarray_EXECUTABLE} ${Coarray_NUMPROC_FLAG} ${Coarray_MAX_NUMPROCS} $<TARGET_FILE:coarray_pi>)
-
+set_tests_properties(CoarrayPi PROPERTIES TIMEOUT 20 RUN_SERIAL TRUE)

coarray/meson.build

@@ -3,12 +3,17 @@ if not coarray.found()
   subdir_done()
 endif
 
+coarray_ok = fc.run('sync all; end', dependencies: coarray, name:'Coarray runs').returncode() == 0
+if not coarray_ok
+  subdir_done()
+endif
+
 # this needs to be "run" to verify no dll runtime issues, particularly on Windows.
-f18coarray = fc.run('real :: x[*]; call co_sum(x); end', dependencies: coarray, name: 'F2018 coarray').returncode() == 0
+f18coarray = fc.run('real :: x[*]; call co_sum(x); sync all; end', dependencies: coarray, name: 'F2018 coarray').returncode() == 0
 
 hello = executable('coarray_hello', 'helloworld.f90',
   dependencies : coarray)
-test('Coarray Hello', hello)
+test('Coarray Hello', hello, timeout: 20, is_parallel : false)
 
 
 # Intel >= 20 supports Fortran 2018 co_sum
@@ -18,4 +23,4 @@ else
   pi = executable('coarray_pi', 'pi2008.f90', dependencies : coarray)
 endif
 
-test('Coarray Pi', pi)
+test('Coarray Pi', pi, timeout: 20, is_parallel : false)

coarray/pi.f90

@@ -41,8 +41,7 @@
 !    print *,x,f,psum
 end do
 
-! --- co_sum is much simpler, but not included even in ifort 2019
-call co_sum(psum)!, stat=stat,errmsg=emsg)
+call co_sum(psum)!, stat=stat, errmsg=emsg)
 !if (stat /= 0) then
 !   write (stderr,*) emsg
 !   error stop
@@ -56,7 +55,7 @@
 if (im == 1) then
     call system_clock(toc)
     call system_clock(count_rate=rate)
-    telaps = real((toc - tic),wp)  / rate
+    telaps = real((toc - tic), wp)  / rate
     print '(A,E9.3,A,I3,A)', 'Elapsed wall clock time ', telaps, ' seconds, using',num_images(),' images.'
 end if
 

contiguous/meson.build

@@ -1,3 +1,8 @@
+if fc.get_id() == 'intel-cl'
+  message('Intel Fortran on Windows has a continuous bug')
+  subdir_done()
+endif
+
 if fc.links('contig = is_contiguous([1,2,3]); end', name: 'F2008 contiguous')
   f08contig='-DISCONTIG'
 else

cxx/CMakeLists.txt

@@ -22,7 +22,7 @@ target_compile_options(f_call_c PRIVATE ${FFLAGS})
 add_test(NAME Fortran2C COMMAND f_call_c)
 
 # Workaround for PGI not having CXX on Windows and wrong CXX compiler being found
-if(WIN32 AND CMAKE_C_COMPILER_ID STREQUAL PGI)
+if(WIN32 AND CMAKE_C_COMPILER_ID STREQUAL PGI OR CMAKE_Fortran_COMPILER_ID STREQUAL PGI)
   message(STATUS "PGI on Windows does not currently have a CXX compiler")
   return()
 endif()

io/CMakeLists.txt

@@ -1,10 +1,14 @@
 add_library(logging logging.f90)
 target_compile_options(logging PRIVATE ${FFLAGS})
 
-add_executable(append_file append_file.f90)
-target_compile_options(append_file PRIVATE ${FFLAGS})
-target_link_libraries(append_file PRIVATE logging)
-add_test(NAME AppendFile COMMAND append_file)
+if(CMAKE_Fortran_COMPILER_ID STREQUAL PGI)
+  message(STATUS "PGI doesn't work correctly for this append_file example, even alone")
+else()
+  add_executable(append_file append_file.f90)
+  target_compile_options(append_file PRIVATE ${FFLAGS})
+  target_link_libraries(append_file PRIVATE logging)
+  add_test(NAME AppendFile COMMAND append_file)
+endif()
 
 add_executable(termio terminal_io.f90)
 target_compile_options(termio PRIVATE ${FFLAGS})

lapack95/CMakeLists.txt

@@ -1,18 +1,7 @@
-cmake_minimum_required (VERSION 3.12)
-if(NOT CMAKE_BUILD_TYPE)
-  set(CMAKE_BUILD_TYPE Release CACHE STRING "Debug or Release")
+if(WIN32 AND CMAKE_Fortran_COMPILER_ID STREQUAL PGI)
+  message(STATUS "skipping: PGI Lapack is buggy on Windows")
+  return()
 endif()
-project(fortran2018array C Fortran)  # C is necessary for MKL detection!
-enable_testing()
-
-cmake_policy(SET CMP0074 NEW)
-
-get_directory_property(hasParent PARENT_DIRECTORY)
-if(NOT hasParent)
-  include(${CMAKE_CURRENT_SOURCE_DIR}/../cmake/compilers.cmake)
-  list(APPEND CMAKE_MODULE_PATH ${CMAKE_CURRENT_SOURCE_DIR}/../cmake/Modules/)
-endif()
-
 
 if(DEFINED ENV{MKLROOT})
   set(USEMKL 1)
@@ -22,7 +11,6 @@ else()
   find_package(LAPACK COMPONENTS LAPACK95)
 endif()
 
-
 if(LAPACK_LAPACK95_FOUND)
   add_executable(svd demo_gesvd.F90)
   target_link_libraries(svd PRIVATE ${LAPACK_LIBRARIES} ${FLIBS})