Skip to content

Commit c7329f0

Browse files
Upgraded Scala.js to v1.5.1 (#4)
1 parent 85a99b5 commit c7329f0

File tree

7 files changed

+10
-33
lines changed

7 files changed

+10
-33
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
[![CI](https://github.com/scommons/scommons-api/actions/workflows/ci.yml/badge.svg?branch=master)](https://github.com/scommons/scommons-api/actions/workflows/ci.yml?query=workflow%3Aci+branch%3Amaster)
33
[![Coverage Status](https://coveralls.io/repos/github/scommons/scommons-api/badge.svg?branch=master)](https://coveralls.io/github/scommons/scommons-api?branch=master)
44
[![scala-index](https://index.scala-lang.org/scommons/scommons-api/scommons-api-core/latest.svg)](https://index.scala-lang.org/scommons/scommons-api/scommons-api-core)
5-
[![Scala.js](https://www.scala-js.org/assets/badges/scalajs-1.1.0.svg)](https://www.scala-js.org)
5+
[![Scala.js](https://www.scala-js.org/assets/badges/scalajs-1.5.0.svg)](https://www.scala-js.org)
66

77
## scommons-api
88
Common REST API Scala/Scala.js components

build.sbt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ lazy val `scommons-api` = (project in file("."))
66
.settings(CommonModule.settings: _*)
77
.settings(ApiModule.settings: _*)
88
.settings(
9-
skip in publish := true,
9+
publish / skip := true,
1010
publish := ((): Unit),
1111
publishLocal := ((): Unit),
1212
publishM2 := ((): Unit)

project/build.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
sbt.version = 1.2.8
1+
sbt.version = 1.5.2

project/plugins.sbt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
//resolvers += "Typesafe repository" at "https://repo.typesafe.com/typesafe/releases/"
22
resolvers += "Sonatype Snapshots" at "https://oss.sonatype.org/content/repositories/snapshots/"
33

4-
//addSbtPlugin(("org.scommons.sbt" % "sbt-scommons-plugin" % "0.8.0-SNAPSHOT").changing())
5-
addSbtPlugin("org.scommons.sbt" % "sbt-scommons-plugin" % "0.8.0")
4+
addSbtPlugin(("org.scommons.sbt" % "sbt-scommons-plugin" % "0.9.0-SNAPSHOT").changing())
5+
//addSbtPlugin("org.scommons.sbt" % "sbt-scommons-plugin" % "0.8.0")
66

77
addSbtPlugin("org.xerial.sbt" % "sbt-sonatype" % "3.9.5")
88
addSbtPlugin("com.jsuereth" % "sbt-pgp" % "1.1.0")
99

10-
addSbtPlugin("org.scoverage" % "sbt-scoverage" % "1.6.1")
10+
addSbtPlugin("org.scoverage" % "sbt-scoverage" % "1.7.3")
1111
addSbtPlugin("org.scoverage" % "sbt-coveralls" % "1.2.7")

project/src/main/scala/definitions/ApiModule.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ object ApiModule {
2525
//
2626
sonatypeProfileName := "org.scommons",
2727
publishMavenStyle := true,
28-
publishArtifact in Test := false,
28+
Test / publishArtifact := false,
2929
publishTo := sonatypePublishToBundle.value,
3030
pomExtra := {
3131
<url>https://github.com/scommons/scommons-api</url>

project/src/main/scala/definitions/ScalaJsModule.scala

Lines changed: 2 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -2,40 +2,17 @@ package definitions
22

33
import org.scalajs.jsenv.nodejs.NodeJSEnv
44
import org.scalajs.sbtplugin.ScalaJSPlugin.autoImport._
5-
import sbt.Keys._
65
import sbt._
7-
import scoverage.ScoverageKeys.{coverageEnabled, coverageScalacPluginVersion}
86

97
object ScalaJsModule {
108

119
val settings: Seq[Setting[_]] = Seq(
1210
// required for node.js >= v12.12.0
1311
// see:
1412
// https://github.com/nodejs/node/pull/29919
15-
jsEnv in Test := new NodeJSEnv(NodeJSEnv.Config().withArgs(List("--enable-source-maps"))),
16-
scalaJSLinkerConfig in Test ~= {
13+
Test / jsEnv := new NodeJSEnv(NodeJSEnv.Config().withArgs(List("--enable-source-maps"))),
14+
Test / scalaJSLinkerConfig ~= {
1715
_.withSourceMap(true)
18-
},
19-
20-
//TODO: remove these temporal fixes for Scala.js 1.1+ and scoverage
21-
coverageScalacPluginVersion := {
22-
val current = coverageScalacPluginVersion.value
23-
if (scalaJSVersion.startsWith("0.6")) current
24-
else "1.4.2" //the only version that supports Scala.js 1.1+
25-
},
26-
libraryDependencies ~= { modules =>
27-
if (scalaJSVersion.startsWith("0.6")) modules
28-
else modules.filter(_.organization != "org.scoverage")
29-
},
30-
libraryDependencies ++= {
31-
if (coverageEnabled.value) {
32-
if (scalaJSVersion.startsWith("0.6")) Nil
33-
else Seq(
34-
"org.scoverage" %% "scalac-scoverage-runtime_sjs1" % coverageScalacPluginVersion.value,
35-
"org.scoverage" %% "scalac-scoverage-plugin" % coverageScalacPluginVersion.value % "scoveragePlugin"
36-
)
37-
}
38-
else Nil
3916
}
4017
)
4118
}

version.sbt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
version in ThisBuild := sys.env.getOrElse("version", default = "1.0.0-SNAPSHOT").stripPrefix("v")
1+
ThisBuild / version := sys.env.getOrElse("version", default = "1.0.0-SNAPSHOT").stripPrefix("v")

0 commit comments

Comments
 (0)