Use Download.path directly (#246)

Author: elacuesta

scrapy_playwright/handler.py

@@ -3,7 +3,6 @@
 from contextlib import suppress
 from dataclasses import dataclass
 from ipaddress import ip_address
-from tempfile import NamedTemporaryFile
 from time import time
 from typing import Awaitable, Callable, Dict, Optional, Tuple, Type, TypeVar, Union
 
@@ -429,10 +428,8 @@ async def _handle_download(dwnld: Download) -> None:
             try:
                 if failure := await dwnld.failure():
                     raise RuntimeError(f"Failed to download {dwnld.url}: {failure}")
-                with NamedTemporaryFile() as temp_file:
-                    await dwnld.save_as(temp_file.name)
-                    temp_file.seek(0)
-                    download["bytes"] = temp_file.read()
+                download_path = await dwnld.path()
+                download["bytes"] = download_path.read_bytes()
                 download["url"] = dwnld.url
                 download["suggested_filename"] = dwnld.suggested_filename
             except Exception as ex:

tests/tests_asyncio/test_playwright_requests.py

@@ -475,22 +475,6 @@ async def test_download_file_delay_error(self):
                     f" exc_type={type(excinfo.value)} exc_msg={str(excinfo.value)}",
                 ) in self._caplog.record_tuples
 
-    @patch("scrapy_playwright.handler.NamedTemporaryFile")
-    @pytest.mark.asyncio
-    async def test_download_file_exception(self, NamedTemporaryFile):
-        NamedTemporaryFile.side_effect = ZeroDivisionError("asdf")
-        async with make_handler({"PLAYWRIGHT_BROWSER_TYPE": self.browser_type}) as handler:
-            with MockServer() as server:
-                request = Request(url=server.urljoin("/mancha.pdf"), meta={"playwright": True})
-                with pytest.raises(ZeroDivisionError) as excinfo:
-                    await handler._download_request(request, Spider("foo"))
-                assert (
-                    "scrapy-playwright",
-                    logging.WARNING,
-                    f"Closing page due to failed request: {request}"
-                    f" exc_type={type(excinfo.value)} exc_msg={str(excinfo.value)}",
-                ) in self._caplog.record_tuples
-
     @pytest.mark.asyncio
     async def test_download_file_failure(self):
         if self.browser_type != "chromium":