From 4f600cea9453e0c46bdb400e5cd67c25376bf888 Mon Sep 17 00:00:00 2001 From: kristianm Date: Wed, 6 May 2026 14:17:00 -0700 Subject: [PATCH 1/4] chore: DEVPLAT-7373 fix Node.js 20 deprecated GitHub Actions --- .github/workflows/release.yml | 3 ++- action.yml | 5 +++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 80cfde9..3d95fad 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -21,8 +21,9 @@ jobs: - name: Semantic Release id: semantic - uses: cycjimmy/semantic-release-action@v4 + uses: cycjimmy/semantic-release-action@v5 with: + semantic_version: 24 extra_plugins: | @semantic-release/changelog@6.0.2 @semantic-release/git@10.0.1 diff --git a/action.yml b/action.yml index 496a0a9..ebdadec 100644 --- a/action.yml +++ b/action.yml @@ -68,13 +68,14 @@ runs: - name: Send notification if: always() - uses: slackapi/slack-github-action@v1.25.0 + uses: slackapi/slack-github-action@v3 env: SLACK_BOT_TOKEN: ${{ inputs.token }} with: - channel-id: ${{ inputs.channel }} + method: chat.postMessage payload: | { + "channel": "${{ inputs.channel }}", "text": ":${{ steps.fields.outputs.emoji }}: *Workflow ${{ inputs.status }}*", "attachments": [ { From 89fc15b85894e66800e26d327e14d4cb8502d3c6 Mon Sep 17 00:00:00 2001 From: kristianm Date: Wed, 6 May 2026 14:45:58 -0700 Subject: [PATCH 2/4] ci: verify SCRIBD_SLACK_GENERIC_TOKEN_PUBLIC is set before running tests [DEVPLAT-7373] --- .github/workflows/ci.yml | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 427b073..e869f42 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -3,7 +3,21 @@ name: CI on: [push, workflow_dispatch] jobs: + verify-secrets: + runs-on: ubuntu-22.04 + steps: + - name: Verify SCRIBD_SLACK_GENERIC_TOKEN_PUBLIC is set + run: | + if [ -z "$TOKEN" ]; then + echo "::error::SCRIBD_SLACK_GENERIC_TOKEN_PUBLIC is not set on this repository — add it to repo or org secrets before merging" + exit 1 + fi + echo "Secret is set" + env: + TOKEN: ${{ secrets.SCRIBD_SLACK_GENERIC_TOKEN_PUBLIC }} + test: + needs: verify-secrets runs-on: ubuntu-22.04 steps: - name: Checkout @@ -16,6 +30,7 @@ jobs: token: ${{ secrets.SCRIBD_SLACK_GENERIC_TOKEN_PUBLIC }} channel: test-release-notification test-custom-message: + needs: verify-secrets runs-on: ubuntu-22.04 steps: - name: Checkout @@ -29,6 +44,7 @@ jobs: channel: test-release-notification message: test-custom-message-with-special-characters: + needs: verify-secrets runs-on: ubuntu-22.04 steps: - name: Checkout @@ -42,6 +58,7 @@ jobs: channel: test-release-notification message: test-overwrite-repository: + needs: verify-secrets runs-on: ubuntu-22.04 steps: - name: Checkout @@ -55,6 +72,7 @@ jobs: channel: test-release-notification repository: scribd/node-chassis test-overwrite-status: + needs: verify-secrets runs-on: ubuntu-22.04 steps: - name: Checkout @@ -68,6 +86,7 @@ jobs: channel: test-release-notification status: failure test-overwrite-environment: + needs: verify-secrets runs-on: ubuntu-22.04 steps: - name: Checkout From 1bc7ee7fa4d7da57238e176fb49068c5eeae784f Mon Sep 17 00:00:00 2001 From: kristianm Date: Wed, 6 May 2026 14:49:37 -0700 Subject: [PATCH 3/4] ci: remove verify-secrets job now that token is confirmed set [DEVPLAT-7373] --- .github/workflows/ci.yml | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index e869f42..427b073 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -3,21 +3,7 @@ name: CI on: [push, workflow_dispatch] jobs: - verify-secrets: - runs-on: ubuntu-22.04 - steps: - - name: Verify SCRIBD_SLACK_GENERIC_TOKEN_PUBLIC is set - run: | - if [ -z "$TOKEN" ]; then - echo "::error::SCRIBD_SLACK_GENERIC_TOKEN_PUBLIC is not set on this repository — add it to repo or org secrets before merging" - exit 1 - fi - echo "Secret is set" - env: - TOKEN: ${{ secrets.SCRIBD_SLACK_GENERIC_TOKEN_PUBLIC }} - test: - needs: verify-secrets runs-on: ubuntu-22.04 steps: - name: Checkout @@ -30,7 +16,6 @@ jobs: token: ${{ secrets.SCRIBD_SLACK_GENERIC_TOKEN_PUBLIC }} channel: test-release-notification test-custom-message: - needs: verify-secrets runs-on: ubuntu-22.04 steps: - name: Checkout @@ -44,7 +29,6 @@ jobs: channel: test-release-notification message: test-custom-message-with-special-characters: - needs: verify-secrets runs-on: ubuntu-22.04 steps: - name: Checkout @@ -58,7 +42,6 @@ jobs: channel: test-release-notification message: test-overwrite-repository: - needs: verify-secrets runs-on: ubuntu-22.04 steps: - name: Checkout @@ -72,7 +55,6 @@ jobs: channel: test-release-notification repository: scribd/node-chassis test-overwrite-status: - needs: verify-secrets runs-on: ubuntu-22.04 steps: - name: Checkout @@ -86,7 +68,6 @@ jobs: channel: test-release-notification status: failure test-overwrite-environment: - needs: verify-secrets runs-on: ubuntu-22.04 steps: - name: Checkout From 66a86b66caa77603e529dd814aedc747ea0a6e76 Mon Sep 17 00:00:00 2001 From: kristianm Date: Wed, 6 May 2026 14:56:10 -0700 Subject: [PATCH 4/4] fix: token passed This reverts commit f98586767ecf03d6e988d1f4e569af61308f66cd. --- action.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/action.yml b/action.yml index ebdadec..75b34d3 100644 --- a/action.yml +++ b/action.yml @@ -69,10 +69,9 @@ runs: - name: Send notification if: always() uses: slackapi/slack-github-action@v3 - env: - SLACK_BOT_TOKEN: ${{ inputs.token }} with: method: chat.postMessage + token: ${{ inputs.token }} payload: | { "channel": "${{ inputs.channel }}",