Skip to content

Commit 29701e5

Browse files
Fixed some Scrutinizer hints
1 parent 0b25ec8 commit 29701e5

File tree

5 files changed

+17
-3
lines changed

5 files changed

+17
-3
lines changed

src/Backup/Cli.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,5 +51,5 @@ protected function execute(Target $target)
5151
* @param \phpbu\App\Backup\Target $target
5252
* @return \phpbu\App\Cli\Executable
5353
*/
54-
public abstract function getExecutable(Target $target);
54+
abstract public function getExecutable(Target $target);
5555
}

src/Backup/Compressor/Directory.php

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,13 @@
2020
*/
2121
class Directory extends Cli
2222
{
23+
/**
24+
* Path to cli binary.
25+
*
26+
* @var string
27+
*/
28+
private $pathToCommand;
29+
2330
/**
2431
* Path to dir to compress.
2532
*

src/Backup/Compressor/File.php

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,13 @@
2020
*/
2121
class File extends Cli
2222
{
23+
/**
24+
* Path to cli binary.
25+
*
26+
* @var string
27+
*/
28+
private $pathToCommand;
29+
2330
/**
2431
* File to dir to compress.
2532
*

src/Backup/Source/Tar.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ public function getExecutable(Target $target)
120120
if (null == $this->executable) {
121121
// check if tar supports requested compression
122122
if ($target->shouldBeCompressed()) {
123-
if(!Executable\Tar::isCompressorValid($target->getCompressor()->getCommand())) {
123+
if (!Executable\Tar::isCompressorValid($target->getCompressor()->getCommand())) {
124124
$this->pathToArchive = $target->getPathnamePlain();
125125
} else {
126126
// compression could be handled by the tar command

src/Cli/Executable/Abstraction.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ public function getProcess()
8282
*
8383
* @return \phpbu\App\Cli\Process
8484
*/
85-
protected abstract function createProcess();
85+
abstract protected function createProcess();
8686

8787
/**
8888
* Show the stdError output.

0 commit comments

Comments
 (0)