Merge branch 'master' into 5.1

Author: sebastianfeldmann

.gitignore

@@ -8,6 +8,7 @@
 /build/coverage
 /build/logs
 /build/phar
+/build/phar-scoped
 /composer.lock
 /phpbu.xml
 /phpbu.json

.travis.yml

@@ -9,9 +9,11 @@ before_script:
   - composer self-update
   - composer install --no-interaction --prefer-source
   - wget -O phpunit.phar https://phar.phpunit.de/phpunit-6.5.6.phar
+  - if [ $TRAVIS_PHP_VERSION = "7.1" ]; then wget -O phpstan.phar https://github.com/phpstan/phpstan/releases/download/0.10.5/phpstan.phar ; fi
 
 script:
   - php phpunit.phar --configuration ./build/travis-ci.phpunit.xml
+  - if [ $TRAVIS_PHP_VERSION = "7.1" ]; then php phpstan.phar analyse --no-progress -c phpstan.neon; fi
 
 after_success:
   - wget https://scrutinizer-ci.com/ocular.phar

README.md

@@ -130,7 +130,7 @@ Simple configuration example:
 ```xml
   <?xml version="1.0" encoding="UTF-8"?>
   <phpbu xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-         xsi:noNamespaceSchemaLocation="http://schema.phpbu.de/5.0/phpbu.xsd"
+         xsi:noNamespaceSchemaLocation="http://schema.phpbu.de/5.1/phpbu.xsd"
          verbose="true">
     <backups>
       <backup name="myAppDB">

phpstan.neon

@@ -0,0 +1,10 @@
+parameters:
+  level: 2
+  paths:
+  - %currentWorkingDirectory%/src/
+  ignoreErrors:
+      - '#Call to an undefined method SebastianFeldmann\\Ftp\\Client::delete\(\)#'
+      - '#Call to an undefined method ObjectStorage_Abstract::setLocalFile\(\)#'
+      - '#Instantiated class phpbu\\App\\Runner\\Restore not found#'
+      - '#Cannot cast DateTimeImmutable to int#'
+      - '#Cannot call method getTimestamp\(\) on string#'

src/Backup/Cleaner/Quantity.php

@@ -76,7 +76,7 @@ protected function getFilesToDelete(Target $target, Collector $collector)
     /**
      * Returns true when the capacity is exceeded.
      *
-     * @param  array
+     * @param  array $files
      * @return bool
      */
     private function isCapacityExceeded(array $files)

src/Backup/Cleaner/Stepwise.php

@@ -96,19 +96,19 @@ protected function setupRanges()
         $all   = new Range($start, $end, new Stepwise\Keeper\All());
 
         // define the range that keeps backups per day
-        $end   = mktime(0, 0, 0, date('m', $end), date('d', $end) - $this->daysToKeepDaily, date('Y', $end));
+        $end   = mktime(0, 0, 0, date('m', $end), (int) date('d', $end) - $this->daysToKeepDaily, date('Y', $end));
         $daily = new Range($all->getEnd(), $end, new Stepwise\Keeper\OnePerGroup('Ymd'));
 
         // define the range that keeps backups per week
-        $end    = mktime(0, 0, 0, date('m', $end), date('d', $end) - (7 * $this->weeksToKeepWeekly), date('Y', $end));
+        $end    = mktime(0, 0, 0, date('m', $end), (int) date('d', $end) - (7 * $this->weeksToKeepWeekly), date('Y', $end));
         $weekly = new Range($daily->getEnd(), $end, new Stepwise\Keeper\OnePerGroup('YW'));
 
         // define the range that keeps backups per month
-        $end     = mktime(0, 0, 0, date('m', $end) - $this->monthToKeepMonthly, date('d', $end), date('Y', $end));
+        $end     = mktime(0, 0, 0, (int) date('m', $end) - $this->monthToKeepMonthly, date('d', $end), date('Y', $end));
         $monthly = new Range($weekly->getEnd(), $end, new Stepwise\Keeper\OnePerGroup('Ym'));
 
         // define the range that keeps backups per year
-        $end    = mktime(0, 0, 0, date('m', $end), date('d', $end), date('Y', $end) - $this->yearsToKeepYearly);
+        $end    = mktime(0, 0, 0, date('m', $end), date('d', $end), (int) date('Y', $end) - $this->yearsToKeepYearly);
         $yearly = new Range($monthly->getEnd(), $end, new Stepwise\Keeper\OnePerGroup('Y'));
 
         // delete all backups older then configured year range

src/Backup/Crypter.php

@@ -27,7 +27,7 @@ public function setup(array $options = []);
      * Checks the created backup.
      *
      * @param  \phpbu\App\Backup\Target $target
-     * @param  \phpbu\App\Result
+     * @param  \phpbu\App\Result $result
      * @throws \phpbu\App\Exception
      */
     public function crypt(Target $target, Result $result);

src/Backup/Source/Arangodump.php

@@ -173,7 +173,7 @@ protected function createExecutable(Target $target) : Executable
     /**
      * Create backup status.
      *
-     * @param  \phpbu\App\Backup\Target
+     * @param  \phpbu\App\Backup\Target $target
      * @return \phpbu\App\Backup\Source\Status
      */
     protected function createStatus(Target $target) : Status

src/Backup/Source/Mongodump.php

@@ -189,7 +189,7 @@ protected function createExecutable(Target $target) : Executable
     /**
      * Create backup status.
      *
-     * @param  \phpbu\App\Backup\Target
+     * @param  \phpbu\App\Backup\Target $target
      * @return \phpbu\App\Backup\Source\Status
      */
     protected function createStatus(Target $target) : Status

src/Backup/Source/Mysqldump.php

@@ -281,7 +281,7 @@ protected function createExecutable(Target $target) : Executable
     /**
      * Create backup status.
      *
-     * @param  \phpbu\App\Backup\Target
+     * @param  \phpbu\App\Backup\Target $target
      * @return \phpbu\App\Backup\Source\Status
      */
     protected function createStatus(Target $target) : Status