Merge pull request #250 from open-source-contributions

Improve test stuffs

Author: sebastianfeldmann

tests/phpbu/Adapter/DotEnvTest.php

@@ -1,6 +1,8 @@
 <?php
 namespace phpbu\App\Adapter;
 
+use PHPUnit\Framework\TestCase;
+
 /**
  * Factory test
  *
@@ -12,7 +14,7 @@
  * @link       http://www.phpbu.de/
  * @since      Class available since Release 1.1.5
  */
-class DotenvTest extends \PHPUnit\Framework\TestCase
+class DotenvTest extends TestCase
 {
     /**
      * Tests DotEnv::setUp

tests/phpbu/Adapter/EnvTest.php

@@ -1,6 +1,8 @@
 <?php
 namespace phpbu\App\Adapter;
 
+use PHPUnit\Framework\TestCase;
+
 /**
  * Env test
  *
@@ -12,7 +14,7 @@
  * @link       http://www.phpbu.de/
  * @since      Class available since Release 4.0.0
  */
-class EnvTest extends \PHPUnit\Framework\TestCase
+class EnvTest extends TestCase
 {
     /**
      * Tests Env::setup

tests/phpbu/Adapter/PHPArrayTest.php

@@ -1,6 +1,8 @@
 <?php
 namespace phpbu\App\Adapter;
 
+use PHPUnit\Framework\TestCase;
+
 /**
  * Env test
  *
@@ -12,7 +14,7 @@
  * @link       http://www.phpbu.de/
  * @since      Class available since Release 4.0.0
  */
-class PHPArrayTest extends \PHPUnit\Framework\TestCase
+class PHPArrayTest extends TestCase
 {
     /**
      * Tests PHPArray::setup

tests/phpbu/Adapter/UtilTest.php

@@ -1,6 +1,8 @@
 <?php
 namespace phpbu\App\Adapter;
 
+use PHPUnit\Framework\TestCase;
+
 /**
  * Adapter Util test
  *
@@ -12,7 +14,7 @@
  * @link       http://www.phpbu.de/
  * @since      Class available since Release 5.0.7
  */
-class UtilTest extends \PHPUnit\Framework\TestCase
+class UtilTest extends TestCase
 {
     /**
      * Tests Util::getAdapterReplacements
@@ -21,7 +23,7 @@ public function testGetAdapterValuesSingle()
     {
         $values = Util::getAdapterReplacements('adapter:foo:bar');
 
-        $this->assertEquals(1, count($values));
+        $this->assertCount(1, $values);
         $this->assertEquals('adapter:foo:bar', $values[0]['search']);
         $this->assertEquals('foo', $values[0]['adapter']);
         $this->assertEquals('bar', $values[0]['path']);
@@ -34,7 +36,7 @@ public function testGetAdapterValuesSinglePrefixed()
     {
         $values = Util::getAdapterReplacements(':AdaPteR:foo:bar');
 
-        $this->assertEquals(1, count($values));
+        $this->assertCount(1, $values);
         $this->assertEquals(':AdaPteR:foo:bar', $values[0]['search']);
         $this->assertEquals('foo', $values[0]['adapter']);
         $this->assertEquals('bar', $values[0]['path']);
@@ -47,7 +49,7 @@ public function testGetAdapterValuesSinglePostfixed()
     {
         $values = Util::getAdapterReplacements('adapter:foo:bar:');
 
-        $this->assertEquals(1, count($values));
+        $this->assertCount(1, $values);
         $this->assertEquals('adapter:foo:bar:', $values[0]['search']);
         $this->assertEquals('foo', $values[0]['adapter']);
         $this->assertEquals('bar', $values[0]['path']);
@@ -60,7 +62,7 @@ public function testGetAdapterValuesSinglePreAndPostfixed()
     {
         $values = Util::getAdapterReplacements(':adapter:foo:bar:');
 
-        $this->assertEquals(1, count($values));
+        $this->assertCount(1, $values);
         $this->assertEquals(':adapter:foo:bar:', $values[0]['search']);
         $this->assertEquals('foo', $values[0]['adapter']);
         $this->assertEquals('bar', $values[0]['path']);
@@ -73,7 +75,7 @@ public function testGetAdapterValuesMultiple()
     {
         $values = Util::getAdapterReplacements('adapter:foo:bar:/some/path/:adapter:fiz:baz');
 
-        $this->assertEquals(2, count($values));
+        $this->assertCount(2, $values);
         $this->assertEquals('adapter:foo:bar:', $values[0]['search']);
         $this->assertEquals('foo', $values[0]['adapter']);
         $this->assertEquals('bar', $values[0]['path']);
@@ -90,7 +92,7 @@ public function testGetAdapterValuesMultipleInBetween()
     {
         $values = Util::getAdapterReplacements('/some/:adapter:foo:bar:/path/:adapter:fiz:baz:/end/');
 
-        $this->assertEquals(2, count($values));
+        $this->assertCount(2, $values);
         $this->assertEquals(':adapter:foo:bar:', $values[0]['search']);
         $this->assertEquals('foo', $values[0]['adapter']);
         $this->assertEquals('bar', $values[0]['path']);

tests/phpbu/Backup/Check/SizeMinTest.php

@@ -1,6 +1,8 @@
 <?php
 namespace phpbu\App\Backup\Check;
 
+use PHPUnit\Framework\TestCase;
+
 /**
  * SizeMinTest
  *
@@ -12,7 +14,7 @@
  * @link       http://www.phpbu.de/
  * @since      Class available since Release 1.0.0
  */
-class SizeMinTest extends \PHPUnit\Framework\TestCase
+class SizeMinTest extends TestCase
 {
     /**
      * Tests SizeMin::pass

tests/phpbu/Backup/Cleaner/OutdatedTest.php

@@ -90,7 +90,7 @@ public function testCleanupDeleteFiles()
         $collectorStub->method('getBackupFiles')->willReturn($fileList);
 
         $cleaner = new Outdated();
-        $cleaner->setup(array('older' => '3d'));
+        $cleaner->setup(['older' => '3d']);
 
         $cleaner->cleanup($targetStub, $collectorStub, $resultStub);
     }
@@ -164,7 +164,7 @@ public function testCleanupNotWritable()
         $collectorStub->method('getBackupFiles')->willReturn($fileList);
 
         $cleaner = new Outdated();
-        $cleaner->setup(array('older' => '3d'));
+        $cleaner->setup(['older' => '3d']);
 
         $cleaner->cleanup($targetStub, $collectorStub, $resultStub);
     }

tests/phpbu/Backup/Cleaner/Stepwise/Keeper/AllTest.php

@@ -1,6 +1,8 @@
 <?php
 namespace phpbu\App\Backup\Cleaner\Stepwise\Keeper;
 
+use PHPUnit\Framework\TestCase;
+
 /**
  * All test
  *
@@ -12,7 +14,7 @@
  * @link       http://www.phpbu.de/
  * @since      Class available since Release 5.0.0
  */
-class AllTest extends \PHPUnit\Framework\TestCase
+class AllTest extends TestCase
 {
     /**
      * Tests All::keep

tests/phpbu/Backup/Cleaner/Stepwise/Keeper/NoneTest.php

@@ -1,6 +1,8 @@
 <?php
 namespace phpbu\App\Backup\Cleaner\Stepwise\Keeper;
 
+use PHPUnit\Framework\TestCase;
+
 /**
  * All test
  *
@@ -12,7 +14,7 @@
  * @link       http://www.phpbu.de/
  * @since      Class available since Release 5.0.0
  */
-class NoneTest extends \PHPUnit\Framework\TestCase
+class NoneTest extends TestCase
 {
     /**
      * Tests None::keep

tests/phpbu/Backup/Cleaner/Stepwise/Keeper/OnePerGroupTest.php

@@ -1,6 +1,8 @@
 <?php
 namespace phpbu\App\Backup\Cleaner\Stepwise\Keeper;
 
+use PHPUnit\Framework\TestCase;
+
 /**
  * OnePerGroup test
  *
@@ -12,7 +14,7 @@
  * @link       http://www.phpbu.de/
  * @since      Class available since Release 5.0.0
  */
-class OnePerGroupTest extends \PHPUnit\Framework\TestCase
+class OnePerGroupTest extends TestCase
 {
     /**
      * Tests OnePerGroup::keep

tests/phpbu/Backup/Cleaner/Stepwise/RangeTest.php

@@ -1,6 +1,8 @@
 <?php
 namespace phpbu\App\Backup\Cleaner\Stepwise;
 
+use PHPUnit\Framework\TestCase;
+
 /**
  * Range test
  *
@@ -12,7 +14,7 @@
  * @link       http://www.phpbu.de/
  * @since      Class available since Release 5.0.0
  */
-class RangeTest extends \PHPUnit\Framework\TestCase
+class RangeTest extends TestCase
 {
     /**
      * Tests Range::getStart